Bug 171604 - Cleanup: Remove out-of-date comment and null check from DocumentLoader::detachFromFrame()
Summary: Cleanup: Remove out-of-date comment and null check from DocumentLoader::detac...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks: 186081
  Show dependency tree / graph
 
Reported: 2017-05-03 09:45 PDT by Daniel Bates
Modified: 2018-05-29 21:09 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.21 KB, patch)
2017-05-03 09:46 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2017-05-03 09:45:50 PDT 
We no longer want to passively allow DocumentLoader::detachFromFrame() to be called twice as it never makes sense to for it to be called twice and indicates a bug that we want to fix. A release assert in DocumentLoader::cancelPolicyCheckIfNeeded() (added in r187558) called by DocumentLoader::detachFromFrame() enforces this invariant. We should remove the unnecessary null check of DocumentLoader::m_frameand the comment that explains this null check from DocumentLoader::detachFromFrame().
Comment 1 Daniel Bates 2017-05-03 09:46:12 PDT 
(In reply to Daniel Bates from comment #0)
> [...]
> the unnecessary null check of DocumentLoader::m_frameand the comment that
> explains this null check from DocumentLoader::detachFromFrame().

*DocumentLoader::m_frame and
Comment 2 Daniel Bates 2017-05-03 09:46:52 PDT 
Created attachment 308915 [details]
Patch
Comment 3 Daniel Bates 2017-05-03 09:52:45 PDT 
Comment on attachment 308915 [details]
Patch

Clearing flags on attachment: 308915

Committed r216119: <http://trac.webkit.org/changeset/216119>
Comment 4 Daniel Bates 2017-05-03 09:52:47 PDT 
All reviewed patches have been landed.  Closing bug.