Bug 171603 - YouTube user agent quirk breaks new YouTube
Summary: YouTube user agent quirk breaks new YouTube
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-03 09:04 PDT by Michael Catanzaro
Modified: 2017-08-31 11:03 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.11 KB, patch)
2017-05-03 09:07 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2017-05-03 09:04:15 PDT
Our user agent quirk to make YouTube 360 work breaks the new YouTube UI, causing it to attempt to use the obsolete custom elements v0 API. WebKit only supports the v1 API. We have to remove this quirk.

Note this does not affect Safari as Apple ports don't use our user agent quirks.
Comment 1 Michael Catanzaro 2017-05-03 09:07:42 PDT
Created attachment 308908 [details]
Patch
Comment 2 Michael Catanzaro 2017-05-03 13:21:18 PDT
"""
This preview is closed... for now
Thanks for your interest in helping us with the new desktop design! We've got a ton of feedback we're reading through, so we've closed the opt-in.
"""

So, I was apparently too slow and can't test this patch anymore... also, YouTube is crashing in trunk on bug #171336. But disabling/enabling site-specific quirks in MiniBrowser definitely toggled the problem when I tested it earlier today. So let's go with this.
Comment 3 WebKit Commit Bot 2017-05-03 13:51:04 PDT
Comment on attachment 308908 [details]
Patch

Clearing flags on attachment: 308908

Committed r216139: <http://trac.webkit.org/changeset/216139>
Comment 4 WebKit Commit Bot 2017-05-03 13:51:06 PDT
All reviewed patches have been landed.  Closing bug.