Bug 171592 - Add mute to WebPlaybackSessionModel.
Summary: Add mute to WebPlaybackSessionModel.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-02 20:39 PDT by Jeremy Jones
Modified: 2017-05-04 16:18 PDT (History)
4 users (show)

See Also:


Attachments
Patch (27.06 KB, patch)
2017-05-02 20:45 PDT, Jeremy Jones
no flags Details | Formatted Diff | Diff
Patch (26.81 KB, patch)
2017-05-02 20:50 PDT, Jeremy Jones
jeremyj-wk: review-
Details | Formatted Diff | Diff
Patch (26.08 KB, patch)
2017-05-03 17:10 PDT, Jeremy Jones
no flags Details | Formatted Diff | Diff
Patch (23.32 KB, patch)
2017-05-04 14:12 PDT, Jeremy Jones
no flags Details | Formatted Diff | Diff
Patch (23.28 KB, patch)
2017-05-04 14:18 PDT, Jeremy Jones
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2017-05-02 20:39:20 PDT
Add mute and increaseVolume and decreaseVolume to WebPlaybackSessionModel.
Comment 1 Jeremy Jones 2017-05-02 20:45:06 PDT
Created attachment 308886 [details]
Patch
Comment 2 Jeremy Jones 2017-05-02 20:45:52 PDT
rdar://problem/31814074
Comment 3 Jeremy Jones 2017-05-02 20:50:28 PDT
Created attachment 308887 [details]
Patch
Comment 4 Jeremy Jones 2017-05-03 17:10:33 PDT
Created attachment 308990 [details]
Patch
Comment 5 Jeremy Jones 2017-05-04 14:12:39 PDT
Created attachment 309100 [details]
Patch
Comment 6 Jeremy Jones 2017-05-04 14:18:34 PDT
Created attachment 309102 [details]
Patch
Comment 7 Jer Noble 2017-05-04 14:20:11 PDT
Comment on attachment 309102 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309102&action=review

> Source/WebCore/platform/ios/WebAVPlayerController.mm:433
> +    UNUSED_PARAM(sender);
> +    if (!self.delegate)
> +        return;
> +    self.delegate->toggleMuted();

Nit: this could probably just drop the ! from the if and skip the return.
Comment 8 WebKit Commit Bot 2017-05-04 16:18:51 PDT
Comment on attachment 309102 [details]
Patch

Clearing flags on attachment: 309102

Committed r216216: <http://trac.webkit.org/changeset/216216>
Comment 9 WebKit Commit Bot 2017-05-04 16:18:53 PDT
All reviewed patches have been landed.  Closing bug.