Bug 171590 - Use PassRefPtr less in CompositeEditCommand
Summary: Use PassRefPtr less in CompositeEditCommand
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-02 19:44 PDT by Chris Dumez
Modified: 2017-05-03 11:41 PDT (History)
6 users (show)

See Also:

Attachments
Patch (109.06 KB, patch)
2017-05-02 19:47 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (109.56 KB, patch)
2017-05-02 20:43 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (109.62 KB, patch)
2017-05-03 08:43 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-05-02 19:44:37 PDT 
Use PassRefPtr less in CompositeEditCommand.
Comment 1 Chris Dumez 2017-05-02 19:47:19 PDT 
Created attachment 308881 [details]
Patch
Comment 2 Build Bot 2017-05-02 19:48:16 PDT 
Attachment 308881 [details] did not pass style-queue:


ERROR: Source/WebCore/editing/ApplyStyleCommand.cpp:671:  'styleToApply' is incorrectly named. It should be named 'protector' or 'protectedStyle'.  [readability/naming/protected] [4]
ERROR: Source/WebCore/editing/ApplyStyleCommand.cpp:951:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 2 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Chris Dumez 2017-05-02 20:43:54 PDT 
Created attachment 308885 [details]
Patch
Comment 4 Build Bot 2017-05-02 20:46:30 PDT 
Attachment 308885 [details] did not pass style-queue:


ERROR: Source/WebCore/editing/ApplyStyleCommand.cpp:671:  'styleToApply' is incorrectly named. It should be named 'protector' or 'protectedStyle'.  [readability/naming/protected] [4]
ERROR: Source/WebCore/editing/ApplyStyleCommand.cpp:951:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 2 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Chris Dumez 2017-05-03 08:43:16 PDT 
Created attachment 308907 [details]
Patch
Comment 6 Build Bot 2017-05-03 08:45:35 PDT 
Attachment 308907 [details] did not pass style-queue:


ERROR: Source/WebCore/editing/ApplyStyleCommand.cpp:671:  'styleToApply' is incorrectly named. It should be named 'protector' or 'protectedStyle'.  [readability/naming/protected] [4]
ERROR: Source/WebCore/editing/ApplyStyleCommand.cpp:951:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 2 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Chris Dumez 2017-05-03 11:41:51 PDT 
Comment on attachment 308907 [details]
Patch

Clearing flags on attachment: 308907

Committed r216128: <http://trac.webkit.org/changeset/216128>
Comment 8 Chris Dumez 2017-05-03 11:41:53 PDT 
All reviewed patches have been landed.  Closing bug.