Bug 171582 – ASSERT(mainThreadPthread) in isMainThread() fails.

• Status: NEW
• Component: JavaScriptCore

[Mark Lam]

This is manifest almost every time when running the (soon to be landed) MultithreadedMultiVMExecutionTest in testapi.  JoePeck says the failed assertion is benign.  I'll comment it out for now (with a FIXME) because it is getting in the way of landing a bug and test.

[Mark Lam]

(In reply to Mark Lam from comment #0)
> This is manifest almost every time when running the (soon to be landed)
> MultithreadedMultiVMExecutionTest in testapi.  JoePeck says the failed
> assertion is benign.  I'll comment it out for now (with a FIXME) because it
> is getting in the way of landing a bug and test.

Specifically, I'm referring to the isMainThread() at the bottom of MainThreadMac.mm.

[Joseph Pecoraro]

Err, you probably shouldn't comment out the assert. It is benign for your use case but it is intended to catch other, more serious issues.

[Mark Lam]

(In reply to Joseph Pecoraro from comment #2)
> Err, you probably shouldn't comment out the assert. It is benign for your
> use case but it is intended to catch other, more serious issues.

OK, I'll comment out my test case and make it dependent on this bug then.  Thanks.

[Mark Lam]

(In reply to Mark Lam from comment #3)
> (In reply to Joseph Pecoraro from comment #2)
> > Err, you probably shouldn't comment out the assert. It is benign for your
> > use case but it is intended to catch other, more serious issues.
> 
> OK, I'll comment out my test case and make it dependent on this bug then. 
> Thanks.

Joe pointed out offline that I can keep my test case as long as I make it call WTF::initializeMainThread() first.  I went with that approach.