Bug 171571 - [Win] Remove redundant macros that are set in the CMake config
Summary: [Win] Remove redundant macros that are set in the CMake config
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-02 14:33 PDT by Don Olmstead
Modified: 2017-05-04 19:11 PDT (History)
5 users (show)

See Also:

Attachments
Patch (15.64 KB, patch)
2017-05-02 14:40 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2017-05-02 14:33:19 PDT 
There are a number of macros within the config.h files that are already present in the CMake files. These should be removed.
Comment 1 Don Olmstead 2017-05-02 14:40:21 PDT 
Created attachment 308851 [details]
Patch

Removes any additions of WINVER, _WIN32_WINNT, and NOMINMAX set within WebKit.

Removes the _CRT_RAND_S value as that does not appear to be relevant anymore.

Also removes blocks of code where WINVER is less than the supported value.

Had to remove the definition of _WIN32_WINNT when building ANGLE as it would not compile otherwise.
Comment 2 Brent Fulgham 2017-05-04 18:41:27 PDT 
Comment on attachment 308851 [details]
Patch

Very nice! r=me.
Comment 3 WebKit Commit Bot 2017-05-04 19:11:30 PDT 
Comment on attachment 308851 [details]
Patch

Clearing flags on attachment: 308851

Committed r216227: <http://trac.webkit.org/changeset/216227>
Comment 4 WebKit Commit Bot 2017-05-04 19:11:31 PDT 
All reviewed patches have been landed.  Closing bug.