RESOLVED FIXED 171571
[Win] Remove redundant macros that are set in the CMake config 
https://bugs.webkit.org/show_bug.cgi?id=171571
Summary [Win] Remove redundant macros that are set in the CMake config
Don Olmstead
Reported 2017-05-02 14:33:19 PDT
There are a number of macros within the config.h files that are already present in the CMake files. These should be removed.
Attachments
Patch (15.64 KB, patch)
2017-05-02 14:40 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2017-05-02 14:40:21 PDT
Created attachment 308851 [details] Patch Removes any additions of WINVER, _WIN32_WINNT, and NOMINMAX set within WebKit. Removes the _CRT_RAND_S value as that does not appear to be relevant anymore. Also removes blocks of code where WINVER is less than the supported value. Had to remove the definition of _WIN32_WINNT when building ANGLE as it would not compile otherwise.
Brent Fulgham
Comment 2 2017-05-04 18:41:27 PDT
Comment on attachment 308851 [details] Patch Very nice! r=me.
WebKit Commit Bot
Comment 3 2017-05-04 19:11:30 PDT
Comment on attachment 308851 [details] Patch Clearing flags on attachment: 308851 Committed r216227: <http://trac.webkit.org/changeset/216227>
WebKit Commit Bot
Comment 4 2017-05-04 19:11:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.