RESOLVED FIXED 171568
check-webkit-style should also keep js-test-post[-async].js in sync 
https://bugs.webkit.org/show_bug.cgi?id=171568
Summary check-webkit-style should also keep js-test-post[-async].js in sync
David Kilzer (:ddkilzer)
Reported 2017-05-02 13:57:25 PDT
check-webkit-style should also keep js-test-post[-async].js in sync after the fix in Bug 171424. We should also add a test for map_functions_to_dict() in jstest.py since that method relies on a regular expression built out of bailing wire and duct tape to extract the function source out of a JavaScript file. When it fails, we'll want to add a new test that fails to make it easier to fix.
Attachments
Patch v1 (8.31 KB, patch)
2017-05-02 14:01 PDT, David Kilzer (:ddkilzer) 		joepeck: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2017-05-02 14:01:00 PDT
Created attachment 308850 [details] Patch v1
Joseph Pecoraro
Comment 2 2017-05-02 14:56:58 PDT
Comment on attachment 308850 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=308850&action=review r=me > Tools/Scripts/webkitpy/style/checkers/jstest_unittest.py:31 > +class JSTestTestCase(unittest.TestCase): Maybe JSTestCheckerTestCase? I dunno how these things need to be named.
David Kilzer (:ddkilzer)
Comment 3 2017-05-02 19:48:19 PDT
Comment on attachment 308850 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=308850&action=review >> Tools/Scripts/webkitpy/style/checkers/jstest_unittest.py:31 >> +class JSTestTestCase(unittest.TestCase): > > Maybe JSTestCheckerTestCase? I dunno how these things need to be named. I like that better so we don't have ...TestTest... in the name. (I was cribbing off JSTestCase in js_unittest.py.)
David Kilzer (:ddkilzer)
Comment 4 2017-05-02 20:59:33 PDT
Committed r216110: <http://trac.webkit.org/changeset/216110>
Note You need to log in before you can comment on or make changes to this bug.