Bug 171560 - Add Cocoa API for toggling the MediaDevicesEnabled setting.
Summary: Add Cocoa API for toggling the MediaDevicesEnabled setting.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-02 11:57 PDT by Andrew Gold
Modified: 2017-05-02 14:04 PDT (History)
7 users (show)

See Also:

Attachments
proposed patch (3.57 KB, patch)
2017-05-02 11:58 PDT, Andrew Gold 		youennf: review+
Details | Formatted Diff | Diff
proposed patch v2 (4.10 KB, patch)
2017-05-02 13:09 PDT, Andrew Gold 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Gold 2017-05-02 11:57:54 PDT 
We added a MediaDevicesEnabled setting, but we need Cocoa API to toggle it.
Comment 1 Andrew Gold 2017-05-02 11:58:57 PDT 
Created attachment 308840 [details]
proposed patch
Comment 2 Radar WebKit Bug Importer 2017-05-02 12:01:13 PDT 
<rdar://problem/31942850>
Comment 3 youenn fablet 2017-05-02 12:48:24 PDT 
Comment on attachment 308840 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308840&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h:101
>  @property (nonatomic, setter=_setMediaStreamEnabled:) BOOL _mediaStreamEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));

We probably no longer need this one.
Can you remove it at the same time?
Comment 4 Andrew Gold 2017-05-02 13:03:52 PDT 
(In reply to youenn fablet from comment #3)
> Comment on attachment 308840 [details]
> proposed patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=308840&action=review
> 
> > Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h:101
> >  @property (nonatomic, setter=_setMediaStreamEnabled:) BOOL _mediaStreamEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
> 
> We probably no longer need this one.
> Can you remove it at the same time?

Sure, I will upload another patch now.
Comment 5 Andrew Gold 2017-05-02 13:09:38 PDT 
Created attachment 308844 [details]
proposed patch v2
Comment 6 WebKit Commit Bot 2017-05-02 14:04:52 PDT 
Comment on attachment 308844 [details]
proposed patch v2

Clearing flags on attachment: 308844

Committed r216093: <http://trac.webkit.org/changeset/216093>
Comment 7 WebKit Commit Bot 2017-05-02 14:04:53 PDT 
All reviewed patches have been landed.  Closing bug.