RESOLVED FIXED 171560
Add Cocoa API for toggling the MediaDevicesEnabled setting. 
https://bugs.webkit.org/show_bug.cgi?id=171560
Summary Add Cocoa API for toggling the MediaDevicesEnabled setting.
Andrew Gold
Reported 2017-05-02 11:57:54 PDT
We added a MediaDevicesEnabled setting, but we need Cocoa API to toggle it.
Attachments
proposed patch (3.57 KB, patch)
2017-05-02 11:58 PDT, Andrew Gold 		youennf: review+
DetailsFormatted DiffDiff
proposed patch v2 (4.10 KB, patch)
2017-05-02 13:09 PDT, Andrew Gold 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrew Gold
Comment 1 2017-05-02 11:58:57 PDT
Created attachment 308840 [details] proposed patch
Radar WebKit Bug Importer
Comment 2 2017-05-02 12:01:13 PDT
<rdar://problem/31942850>
youenn fablet
Comment 3 2017-05-02 12:48:24 PDT
Comment on attachment 308840 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=308840&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h:101 > @property (nonatomic, setter=_setMediaStreamEnabled:) BOOL _mediaStreamEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA)); We probably no longer need this one. Can you remove it at the same time?
Andrew Gold
Comment 4 2017-05-02 13:03:52 PDT
(In reply to youenn fablet from comment #3) > Comment on attachment 308840 [details] > proposed patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=308840&action=review > > > Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h:101 > > @property (nonatomic, setter=_setMediaStreamEnabled:) BOOL _mediaStreamEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA)); > > We probably no longer need this one. > Can you remove it at the same time? Sure, I will upload another patch now.
Andrew Gold
Comment 5 2017-05-02 13:09:38 PDT
Created attachment 308844 [details] proposed patch v2
WebKit Commit Bot
Comment 6 2017-05-02 14:04:52 PDT
Comment on attachment 308844 [details] proposed patch v2 Clearing flags on attachment: 308844 Committed r216093: <http://trac.webkit.org/changeset/216093>
WebKit Commit Bot
Comment 7 2017-05-02 14:04:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.