Bug 171558 - Mac cmake buildfix after r216037
Summary: Mac cmake buildfix after r216037
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2017-05-02 11:06 PDT by Derek Schuff
Modified: 2017-05-05 11:10 PDT (History)
3 users (show)

See Also:

Patch (1.18 KB, patch)
2017-05-04 12:31 PDT, Derek Schuff
no flags Details | Formatted Diff | Diff
Patch (1.21 KB, patch)
2017-05-05 08:53 PDT, Derek Schuff
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Derek Schuff 2017-05-02 11:06:41 PDT
UIProcess/API/Cocoa/WKURLSchemeHandlerTask.mm was renamed in r216037 and the CMake build was not updated.
Comment 2 JF Bastien 2017-05-02 11:54:54 PDT
got baby on me. can't fix now
Comment 3 Derek Schuff 2017-05-02 13:53:51 PDT
I don't have my mac with me today, might be able to get to it tomorrow if nobody else does.
Comment 4 Derek Schuff 2017-05-04 12:31:35 PDT
Created attachment 309086 [details]
Comment 5 JF Bastien 2017-05-04 17:27:00 PDT
Comment on attachment 309086 [details]

Comment 6 WebKit Commit Bot 2017-05-04 17:27:47 PDT
Comment on attachment 309086 [details]

Rejecting attachment 309086 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 309086, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/3675629
Comment 7 JF Bastien 2017-05-04 17:29:55 PDT
The patch is missing the review boiler plate. Can you update with my name? Usually CQ would update the default Unreviewed but since it's not the it is le sad.
Comment 8 Derek Schuff 2017-05-05 08:53:21 PDT
Created attachment 309170 [details]
Comment 9 Derek Schuff 2017-05-05 08:54:14 PDT
Yeah sorry the webkit-patch script kept crashing, so i just added the incomplete boilerplate myself .
Comment 10 WebKit Commit Bot 2017-05-05 11:10:44 PDT
Comment on attachment 309170 [details]

Clearing flags on attachment: 309170

Committed r216248: <http://trac.webkit.org/changeset/216248>
Comment 11 WebKit Commit Bot 2017-05-05 11:10:45 PDT
All reviewed patches have been landed.  Closing bug.