RESOLVED FIXED 171549
Document style resolvers should share user rulesets 
https://bugs.webkit.org/show_bug.cgi?id=171549
Summary Document style resolvers should share user rulesets
Antti Koivisto
Reported 2017-05-02 05:59:31 PDT
User style is per-document. We can save memory and work by sharing it between document and shadow trees.
Attachments
patch (7.48 KB, patch)
2017-05-02 06:12 PDT, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
patch (7.65 KB, patch)
2017-05-02 10:42 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2017-05-02 06:12:15 PDT
Created attachment 308819 [details] patch
Andreas Kling
Comment 2 2017-05-02 06:58:18 PDT
Comment on attachment 308819 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=308819&action=review r=me, this nicely fixes 50% of what i complained about :) What about frames though! > Source/WebCore/ChangeLog:8 > + Large user stylesheets (like those user by add blockers) can end up using lots of memory if "add blockers" jeez
Antti Koivisto
Comment 3 2017-05-02 07:32:56 PDT
https://trac.webkit.org/r216069
Ryan Haddad
Comment 4 2017-05-02 09:22:58 PDT
Reverted r216069 for reason: This change broke the build. Committed r216071: <http://trac.webkit.org/changeset/216071>
Ryan Haddad
Comment 5 2017-05-02 09:23:22 PDT
(In reply to Ryan Haddad from comment #4) > Reverted r216069 for reason: > > This change broke the build. > > Committed r216071: <http://trac.webkit.org/changeset/216071> https://build.webkit.org/builders/Apple%20Sierra%20Release%20%28Build%29/builds/1337
Antti Koivisto
Comment 6 2017-05-02 10:42:22 PDT
Created attachment 308834 [details] patch
Radar WebKit Bug Importer
Comment 7 2017-05-02 10:43:05 PDT
<rdar://problem/31940552>
WebKit Commit Bot
Comment 8 2017-05-02 12:02:47 PDT
Comment on attachment 308834 [details] patch Clearing flags on attachment: 308834 Committed r216083: <http://trac.webkit.org/changeset/216083>
WebKit Commit Bot
Comment 9 2017-05-02 12:02:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.