Bug 171549 - Document style resolvers should share user rulesets
Summary: Document style resolvers should share user rulesets
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-02 05:59 PDT by Antti Koivisto
Modified: 2017-05-02 12:02 PDT (History)
4 users (show)

See Also:


Attachments
patch (7.48 KB, patch)
2017-05-02 06:12 PDT, Antti Koivisto
kling: review+
Details | Formatted Diff | Diff
patch (7.65 KB, patch)
2017-05-02 10:42 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2017-05-02 05:59:31 PDT
User style is per-document. We can save memory and work by sharing it between document and shadow trees.
Comment 1 Antti Koivisto 2017-05-02 06:12:15 PDT
Created attachment 308819 [details]
patch
Comment 2 Andreas Kling 2017-05-02 06:58:18 PDT
Comment on attachment 308819 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308819&action=review

r=me, this nicely fixes 50% of what i complained about :)
What about frames though!

> Source/WebCore/ChangeLog:8
> +        Large user stylesheets (like those user by add blockers) can end up using lots of memory if

"add blockers" jeez
Comment 3 Antti Koivisto 2017-05-02 07:32:56 PDT
https://trac.webkit.org/r216069
Comment 4 Ryan Haddad 2017-05-02 09:22:58 PDT
Reverted r216069 for reason:

This change broke the build.

Committed r216071: <http://trac.webkit.org/changeset/216071>
Comment 5 Ryan Haddad 2017-05-02 09:23:22 PDT
(In reply to Ryan Haddad from comment #4)
> Reverted r216069 for reason:
> 
> This change broke the build.
> 
> Committed r216071: <http://trac.webkit.org/changeset/216071>

https://build.webkit.org/builders/Apple%20Sierra%20Release%20%28Build%29/builds/1337
Comment 6 Antti Koivisto 2017-05-02 10:42:22 PDT
Created attachment 308834 [details]
patch
Comment 7 Radar WebKit Bug Importer 2017-05-02 10:43:05 PDT
<rdar://problem/31940552>
Comment 8 WebKit Commit Bot 2017-05-02 12:02:47 PDT
Comment on attachment 308834 [details]
patch

Clearing flags on attachment: 308834

Committed r216083: <http://trac.webkit.org/changeset/216083>
Comment 9 WebKit Commit Bot 2017-05-02 12:02:48 PDT
All reviewed patches have been landed.  Closing bug.