Bug 171514 - [Cocoa] Replace uses of [get…Class() alloc] in Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm
Summary: [Cocoa] Replace uses of [get…Class() alloc] in Source/WebCore/platform/ios/We...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on: 146862 171486
Blocks:
  Show dependency tree / graph
 
Reported: 2017-05-01 14:27 PDT by David Kilzer (:ddkilzer)
Modified: 2017-05-01 15:41 PDT (History)
5 users (show)

See Also:

Attachments
Patch v1 (2.28 KB, patch)
2017-05-01 14:35 PDT, David Kilzer (:ddkilzer) 		ddkilzer: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2017-05-01 14:27:47 PDT 
$ ./Tools/Scripts/check-webkit-style --filter=-,+runtime/soft-linked-alloc Source/WebCore
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:447:  Using +alloc with a soft-linked class. Use allocWebAVPictureInPicturePlayerLayerViewInstance() instead.  [runtime/soft-linked-alloc] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:616:  Using +alloc with a soft-linked class. Use allocWebAVPlayerLayerViewInstance() instead.  [runtime/soft-linked-alloc] [4]
Total errors found: 2 in 8492 files
Comment 1 David Kilzer (:ddkilzer) 2017-05-01 14:35:04 PDT 
Created attachment 308769 [details]
Patch v1
Comment 2 David Kilzer (:ddkilzer) 2017-05-01 15:37:52 PDT 
Oh dear, I wonder why WebAVPictureInPicturePlayerLayerView and WebAVPlayerLayerView were soft-linked differently here?

<https://trac.webkit.org/r187044>
Comment 3 David Kilzer (:ddkilzer) 2017-05-01 15:41:03 PDT 
(In reply to David Kilzer (:ddkilzer) from comment #2)
> Oh dear, I wonder why WebAVPictureInPicturePlayerLayerView and
> WebAVPlayerLayerView were soft-linked differently here?
> 
> <https://trac.webkit.org/r187044>

Ah, for compatibility reasons.  Okay, there's nothing to do here.