Bug 171513 - API test WebKit2.WebsiteDataStoreCustomPaths is failing on ios-simulator
Summary: API test WebKit2.WebsiteDataStoreCustomPaths is failing on ios-simulator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-01 14:20 PDT by Ryan Haddad
Modified: 2017-05-05 17:08 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.40 KB, patch)
2017-05-04 14:00 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
Patch (4.09 KB, patch)
2017-05-05 16:02 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
Patch (4.16 KB, patch)
2017-05-05 16:16 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
Patch (5.60 KB, patch)
2017-05-05 16:25 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2017-05-01 14:20:18 PDT
[ios-simulator] API test WebKit2.WebsiteDataStoreCustomPaths is failing

FAIL WebKit2.WebsiteDataStoreCustomPaths

/Volumes/Data/slave/ios-simulator-10-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:126
Value of: [[NSFileManager defaultManager] fileExistsAtPath:cookieStoragePath.path]
  Actual: true
Expected: false

https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Release%20WK2%20%28Tests%29/builds/1033
Comment 1 Ryan Haddad 2017-05-01 14:22:21 PDT
This seems to have started with http://trac.webkit.org/changeset/215941
Comment 2 Ryan Haddad 2017-05-02 15:27:12 PDT
Brady, do you have time to take a look at this?
Comment 3 Brady Eidson 2017-05-02 15:49:43 PDT
(In reply to Ryan Haddad from comment #2)
> Brady, do you have time to take a look at this?

In a little bit.
Comment 4 Radar WebKit Bug Importer 2017-05-03 17:21:20 PDT
<rdar://problem/31977294>
Comment 5 Brady Eidson 2017-05-03 19:45:12 PDT
I can get to this tomorrow afternoon - In meantime somebody with a fresh checkout (I don't have one available tonight) can just wrap the entire test with an #if PLATFORM(MAC) to stop it messing up iOS bots
Comment 6 Brady Eidson 2017-05-04 14:00:22 PDT
Created attachment 309099 [details]
Patch
Comment 7 WebKit Commit Bot 2017-05-04 14:42:26 PDT
Comment on attachment 309099 [details]
Patch

Clearing flags on attachment: 309099

Committed r216210: <http://trac.webkit.org/changeset/216210>
Comment 8 WebKit Commit Bot 2017-05-04 14:42:28 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Brady Eidson 2017-05-04 15:14:06 PDT
That was just to skip the test for now - This bug still needs to remain open.
Comment 10 Brady Eidson 2017-05-05 16:02:28 PDT
Created attachment 309229 [details]
Patch
Comment 11 Brady Eidson 2017-05-05 16:16:30 PDT
Created attachment 309235 [details]
Patch
Comment 12 Brady Eidson 2017-05-05 16:25:27 PDT
Created attachment 309238 [details]
Patch
Comment 13 WebKit Commit Bot 2017-05-05 17:08:45 PDT
Comment on attachment 309238 [details]
Patch

Clearing flags on attachment: 309238

Committed r216297: <http://trac.webkit.org/changeset/216297>
Comment 14 WebKit Commit Bot 2017-05-05 17:08:47 PDT
All reviewed patches have been landed.  Closing bug.