Bug 171509 - fix check-webkit-style errors in webkitpy about two blank lines before class definitions
Summary: fix check-webkit-style errors in webkitpy about two blank lines before class ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-01 13:08 PDT by Aakash Jain
Modified: 2017-05-01 14:49 PDT (History)
8 users (show)

See Also:

Attachments
Proposed patch (6.94 KB, patch)
2017-05-01 13:14 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
Updated patch. (7.13 KB, patch)
2017-05-01 13:28 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2017-05-01 13:08:38 PDT 
check-webkit-style emits errors in few files in webkitpy about not having two blank lines before class declaration.

e.g.:
ERROR: Tools/Scripts/webkitpy/style/checkers/featuredefines.py:40:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Tools/Scripts/webkitpy/port/device.py:25:  expected 2 blank lines, found 1  [pep8/E302] [5]
Comment 1 Aakash Jain 2017-05-01 13:08:50 PDT 
https://www.python.org/dev/peps/pep-0008/#blank-lines

"Surround top-level function and class definitions with two blank lines.
Method definitions inside a class are surrounded by a single blank line."
Comment 2 Aakash Jain 2017-05-01 13:14:57 PDT 
Created attachment 308756 [details]
Proposed patch
Comment 3 Aakash Jain 2017-05-01 13:28:23 PDT 
Created attachment 308758 [details]
Updated patch.
Comment 4 WebKit Commit Bot 2017-05-01 14:49:31 PDT 
Comment on attachment 308758 [details]
Updated patch.

Clearing flags on attachment: 308758

Committed r216030: <http://trac.webkit.org/changeset/216030>
Comment 5 WebKit Commit Bot 2017-05-01 14:49:33 PDT 
All reviewed patches have been landed.  Closing bug.