Bug 171506 – fix check-webkit-style errors in webkitpy about not having two spaces before inline comment

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

check-webkit-style emits errors in few files in webkitpy about not having two spaces before inline comment. We should fix these.

e.g.:

ERROR: Tools/Scripts/webkitpy/style/checker.py:143:  at least two spaces before inline comment  [pep8/E261] [5]
ERROR: Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:2826:  at least two spaces before inline comment  [pep8/E261] [5]

[Aakash Jain]

Created attachment 308749 [details]
Proposed patch

[Build Bot]

Attachment 308749 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:419:  [SCMTest._shared_test_reverse_diff] Instance of 'SCMTest' has no 'scm' member  [pylint/E1101] [5]
ERROR: Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:706:  [SVNTest.test_create_patch_is_full_patch] Instance of 'SVNTest' has no 'svn_checkout_path' member  [pylint/E1101] [5]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alexey Proskuryakov]

Comment on attachment 308749 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308749&action=review

Do we actually want this rule? It contradicts Webkit style <https://webkit.org/code-style-guidelines/#comments>.

> Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:419
> +        self._setup_webkittools_scripts_symlink(self.scm)  # Git's apply_reverse_diff uses resolve-ChangeLogs

It may be good to take this opportunity to add periods in the end of sentences.

[Aakash Jain]

(In reply to Alexey Proskuryakov from comment #3)
> Do we actually want this rule? It contradicts Webkit style <https://webkit.org/code-style-guidelines/#comments>.

Should we modify the check-webkit-style script then?

[Alexey Proskuryakov]

Seems worth discussing it on webkit-dev.

[Aakash Jain]

Created attachment 325805 [details]
Updated patch

Following PEP8 guidelines https://www.python.org/dev/peps/pep-0008/#inline-comments

[Build Bot]

Attachment 325805 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:419:  [SCMTest._shared_test_reverse_diff] Instance of 'SCMTest' has no 'scm' member  [pylint/E1101] [5]
ERROR: Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:706:  [SVNTest.test_create_patch_is_full_patch] Instance of 'SVNTest' has no 'svn_checkout_path' member  [pylint/E1101] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 325805 [details]
Updated patch

Clearing flags on attachment: 325805

Committed r224548: <https://trac.webkit.org/changeset/224548>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35568992>