Expose viewport-fit instead of clip-to-safe-area
Created attachment 308741 [details] Patch
Attachment 308741 [details] did not pass style-queue: ERROR: Source/WebKit2/Shared/VisibleContentRectUpdateInfo.h:58: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] Total errors found: 1 in 51 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 308741 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308741&action=review > Source/WebCore/dom/ConstantPropertyMap.h:62 > + void updateConstantsForUnobscuredSafeAreaInsets(); Can this just be updateConstantsForSafeAreaInsets()? > Source/WebCore/dom/ViewportArguments.h:59 > float userScalable; > float orientation; > float shrinkToFit; I thought you fixed this crazy float stuff earlier? > Source/WebCore/page/Page.h:335 > + const FloatBoxExtent& unobscuredSafeAreaInsets() const { return m_unobscuredSafeAreaInsets; } Can we just call these safeAreaInsets? Does the "unobscured" add anything? > Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.h:259 > + void setAvoidUnsafeArea(bool avoidUnsafeArea) { m_avoidUnsafeArea = avoidUnsafeArea; } avoids? > Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.h:302 > + bool m_avoidUnsafeArea { true }; avoids? > Source/WebKit2/UIProcess/PageClient.h:391 > + virtual void didChangeAvoidUnsafeArea(bool avoidUnsafeArea) = 0; avoids > Source/WebKit2/UIProcess/WebPageProxy.h:1204 > + void setAvoidUnsafeArea(bool); > + bool avoidUnsafeArea() const { return m_avoidUnsafeArea; } avoids > Source/WebKit2/UIProcess/ios/PageClientImplIOS.h:201 > + void didChangeAvoidUnsafeArea(bool avoidUnsafeArea) override; avoids
(In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 308741 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=308741&action=review > > > Source/WebCore/dom/ConstantPropertyMap.h:62 > > + void updateConstantsForUnobscuredSafeAreaInsets(); > > Can this just be updateConstantsForSafeAreaInsets()? Yes. > > Source/WebCore/dom/ViewportArguments.h:59 > > float userScalable; > > float orientation; > > float shrinkToFit; > > I thought you fixed this crazy float stuff earlier? I only fixed the new one, haven't gone back and fixed the others yet. > > Source/WebCore/page/Page.h:335 > > + const FloatBoxExtent& unobscuredSafeAreaInsets() const { return m_unobscuredSafeAreaInsets; } > > Can we just call these safeAreaInsets? Yes. > Does the "unobscured" add anything? Only in my head. > > Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.h:259 > > + void setAvoidUnsafeArea(bool avoidUnsafeArea) { m_avoidUnsafeArea = avoidUnsafeArea; } > > avoids? Sure.
Comment on attachment 308741 [details] Patch Attachment 308741 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3652968 New failing tests: fast/css/variables/constants/ios/safe-area-inset-set.html
Created attachment 308761 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
(In reply to Tim Horton from comment #4) > (In reply to Simon Fraser (smfr) from comment #3) > > > Source/WebCore/page/Page.h:335 > > > + const FloatBoxExtent& unobscuredSafeAreaInsets() const { return m_unobscuredSafeAreaInsets; } > > > > Can we just call these safeAreaInsets? > > Yes. > > > Does the "unobscured" add anything? > > Only in my head. Actually, I'm going to leave it, for two reasons. I'll draw you pictures later.
Created attachment 308766 [details] Patch
Created attachment 308768 [details] Patch
Created attachment 308770 [details] Patch
Created attachment 308772 [details] Patch
Already landed in https://trac.webkit.org/changeset/216047/webkit
and the cmake buildfix landed in https://trac.webkit.org/changeset/216326/webkit