Bug 171500 – REGRESSION (r215956): fast/visual-viewport Test Failures

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Matt Lewis]

These test started failing after https://trac.webkit.org/changeset/215956/webkit

On Sierra wk1 this test is failing: fast/visual-viewport/rtl-zoomed-rects.html
https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r215956%20(1117)/results.html

on iOS Simulator:
  fast/visual-viewport/nonzoomed-rects.html [ Failure ]
  fast/visual-viewport/rtl-nonzoomed-rects.html [ Failure ]
  fast/visual-viewport/rtl-zoomed-rects.html [ Failure ]
  fast/visual-viewport/rubberbanding-viewport-rects-extended-background.html [ Failure ]
  fast/visual-viewport/rubberbanding-viewport-rects-header-footer.html [ Failure ]
  fast/visual-viewport/rubberbanding-viewport-rects.html [ Failure ]
  fast/visual-viewport/zoomed-fixed-header-and-footer.html [ Failure ]
  fast/visual-viewport/zoomed-fixed.html [ Failure ]
  fast/visual-viewport/zoomed-rects.html [ Failure ]

https://build.webkit.org/results/Apple%20iOS%2010%20Simulator%20Release%20WK2%20(Tests)/r216013%20(1074)/results.html

[Chris Dumez]

These merely need new baselines because DOMRect has more properties than ClientRect.

[Matt Lewis]

Created attachment 308744 [details]
Patch

[Ryan Haddad]

Comment on attachment 308744 [details]
Patch

Could you go ahead and rebaseline the test that is failing on macOS in the same change?

[Matt Lewis]

Created attachment 308746 [details]
Patch

[Matt Lewis]

(In reply to Ryan Haddad from comment #3)
> Comment on attachment 308744 [details]
> Patch
> 
> Could you go ahead and rebaseline the test that is failing on macOS in the
> same change?

Done

[Build Bot]

Comment on attachment 308746 [details]
Patch

Attachment 308746 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3653171

New failing tests:
fast/visual-viewport/rtl-zoomed-rects.html

[Build Bot]

Created attachment 308762 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Ryan Haddad]

(In reply to Build Bot from comment #6)
> Comment on attachment 308746 [details]
> Patch
> 
> Attachment 308746 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: http://webkit-queues.webkit.org/results/3653171
> 
> New failing tests:
> fast/visual-viewport/rtl-zoomed-rects.html

Ah, what happened here is that your patch should have replaced the expected.txt file for this test in LayoutTests/platform/mac-wk1/fast/visual-viewport/ instead of the one in LayoutTests/fast/visual-viewport/

[Ryan Haddad]

Comment on attachment 308744 [details]
Patch

Clearing flags on attachment: 308744

Committed r216025: <http://trac.webkit.org/changeset/216025>

[Ryan Haddad]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

(In reply to Ryan Haddad from comment #9)
> Comment on attachment 308744 [details]
> Patch
> 
> Clearing flags on attachment: 308744
> 
> Committed r216025: <http://trac.webkit.org/changeset/216025>

I landed your first patch that didn't contain the macOS rebaseline. I took care of the mac part in http://trac.webkit.org/projects/webkit/changeset/216026