Support time@datetime for verbosity clarification of dates, times, and durations * NOTES Looks like the time element covers date, time, and durations. http://www.whatwg.org/specs/web-apps/current-work/multipage/text-level-semantics.html#the-time-element Examples: Duration spoken as "four minutes eighteen seconds" <time datetime="4m 18s">04:18</time> Versus Time spoken as "four eighteen" <time>04:18</time> <!-- implicit --> <time datetime="04:18">04:18</time> <!-- explicit, redundant -->
<rdar://problem/12985540>
Created attachment 308724 [details] patch
Created attachment 308726 [details] patch
Attachment 308726 [details] did not pass style-queue: ERROR: Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1287: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 308727 [details] patch
Do you think it would be worthwhile to add cases to the tests which hold all the roles and elements, if they're not already there, namely roles-exposed.html, roles-computedRoleString.html, and in the case of my platform, gtk/xml-roles-exposed.html? Looking at the mappings, I'm going to have to slap some extra object attributes on it. https://w3c.github.io/html-aam/#el-time, so if you could do roles-exposed.html and roles-computedRoleString.html, that would be great. Once your patch lands, I'll do the stuff for my platform. p.s. Your mappings are a blank says the HTML AAM. One of us should file an issue. If you'd like, I'll do that after your patch lands too.
Comment on attachment 308727 [details] patch Attachment 308727 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3651923 New failing tests: accessibility/roles-computedRoleString.html accessibility/roles-exposed.html
Created attachment 308732 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
(In reply to Joanmarie Diggs (irc: joanie) from comment #6) > Do you think it would be worthwhile to add cases to the tests which hold all > the roles and elements, if they're not already there, namely > roles-exposed.html, roles-computedRoleString.html, and in the case of my > platform, gtk/xml-roles-exposed.html? > > Looking at the mappings, I'm going to have to slap some extra object > attributes on it. https://w3c.github.io/html-aam/#el-time, so if you could > do roles-exposed.html and roles-computedRoleString.html, that would be > great. Once your patch lands, I'll do the stuff for my platform. > Yes will do. Looks like those tests started failing anyway, so there's probably something there > p.s. Your mappings are a blank says the HTML AAM. One of us should file an > issue. If you'd like, I'll do that after your patch lands too. Great thanks!
Comment on attachment 308727 [details] patch Attachment 308727 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3651953 New failing tests: accessibility/roles-computedRoleString.html accessibility/roles-exposed.html
Created attachment 308733 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 308727 [details] patch Attachment 308727 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3652118 New failing tests: accessibility/roles-computedRoleString.html accessibility/roles-exposed.html
Created attachment 308734 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 308747 [details] patch
Created attachment 308754 [details] Additional patch for ATK so tests aren't skipped Chris, the attached provides the WebKitGtk expectations for your new test, the updated expectations for roles-exposed-expected.html, and maps the new TimeRole to ATK_ROLE_STATIC. If it wouldn't be too much trouble for you to include this with the patch you land, it should keep my platform's gardeners from skipping the tests. (Sometimes they are trigger-happy in the spirit of green bots.)
Comment on attachment 308747 [details] patch r+ but please see my comment and attachment. If it wouldn't be too much trouble.... I'll do the object attribute thing tomorrow.
(In reply to Joanmarie Diggs (irc: joanie) from comment #15) > Created attachment 308754 [details] > Additional patch for ATK so tests aren't skipped > > Chris, the attached provides the WebKitGtk expectations for your new test, > the updated expectations for roles-exposed-expected.html, and maps the new > TimeRole to ATK_ROLE_STATIC. If it wouldn't be too much trouble for you to > include this with the patch you land, it should keep my platform's gardeners > from skipping the tests. (Sometimes they are trigger-happy in the spirit of > green bots.) Yep will do
Created attachment 308765 [details] patch
(In reply to chris fleizach from comment #9) > (In reply to Joanmarie Diggs (irc: joanie) from comment #6) > > p.s. Your mappings are a blank says the HTML AAM. One of us should file an > > issue. If you'd like, I'll do that after your patch lands too. > > Great thanks! Issue and pull request to update your platform's mappings: https://github.com/w3c/html-aam/pull/89
Comment on attachment 308765 [details] patch Clearing flags on attachment: 308765 Committed r216038: <http://trac.webkit.org/changeset/216038>
All reviewed patches have been landed. Closing bug.