Expose values of aria-rowcount, aria-colcount, aria-rowindex, aria-colindex, aria-rowspan, and aria-colspan as object attributes
<rdar://problem/31914069>
Created attachment 308720 [details] Patch
Comment on attachment 308720 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308720&action=review > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:416 > + if (coreObject->hasAttribute(HTMLNames::aria_rowspanAttr)) surprised we have to query the attribute directly here. should we make a method to expose rowSpan/colSpan?
(In reply to chris fleizach from comment #3) > Comment on attachment 308720 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=308720&action=review > > > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:416 > > + if (coreObject->hasAttribute(HTMLNames::aria_rowspanAttr)) > > surprised we have to query the attribute directly here. should we make a > method to expose rowSpan/colSpan? We do have a method to expose it, and I use it, e.g. cell.ariaRowSpan(). The problem is that on my platform, the attribute should be exposed if the author has provided it. We return a default value of 1 on the spans, and 1 is valid. So it it author provided or set by WebCore? I could change the return value to 0, as was done with rowcount and colcount, and then modify the platform code. You think I should go that route?
(In reply to Joanmarie Diggs (irc: joanie) from comment #4) > (In reply to chris fleizach from comment #3) > > Comment on attachment 308720 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=308720&action=review > > > > > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:416 > > > + if (coreObject->hasAttribute(HTMLNames::aria_rowspanAttr)) > > > > surprised we have to query the attribute directly here. should we make a > > method to expose rowSpan/colSpan? > > We do have a method to expose it, and I use it, e.g. cell.ariaRowSpan(). > > The problem is that on my platform, the attribute should be exposed if the > author has provided it. We return a default value of 1 on the spans, and 1 > is valid. So it it author provided or set by WebCore? > > I could change the return value to 0, as was done with rowcount and > colcount, and then modify the platform code. You think I should go that > route? It feels like we should be consistent with that model now (0 is no value provided) thanks
Created attachment 308751 [details] Patch
(In reply to chris fleizach from comment #5) > It feels like we should be consistent with that model now (0 is no value > provided) It turns out 0 is a valid value for authors to provide. Returning -1 is consistent with what we do with ariaRowIndex() and ariaColumnIndex().
Comment on attachment 308751 [details] Patch Clearing flags on attachment: 308751 Committed r216028: <http://trac.webkit.org/changeset/216028>
All reviewed patches have been landed. Closing bug.