Bug 171487 – Remove support for legacy Notifications

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Remove support for legacy Notifications

[Sam Weinig]

Created attachment 308703 [details]
Patch

[Sam Weinig]

I discussed this briefly with Jon Lee in the passed, and he was not against the idea on the condition that gmail's use of local notifications still worked. I checked, and gmail's use of local notifications works just fine without legacy notifications.

[Sam Weinig]

Created attachment 308704 [details]
Patch

[Sam Weinig]

First patch didn't apply, but I am thinking the tools may be broken again, and not working for removed files :(. Maybe this second upload will prove me wrong.

[Sam Weinig]

(In reply to Sam Weinig from comment #4)
> First patch didn't apply, but I am thinking the tools may be broken again,
> and not working for removed files :(. Maybe this second upload will prove me
> wrong.

Bummer.

[Sam Weinig]

Filed https://bugs.webkit.org/show_bug.cgi?id=171488 to track the patch applying issue.

[Sam Weinig]

Created attachment 308706 [details]
Patch

[Sam Weinig]

Attempting workout by not removing any directories, only the files within. Will need second pass to remove empty directories.

[Sam Weinig]

Created attachment 308743 [details]
Patch

[Sam Weinig]

Committed r216206: <http://trac.webkit.org/changeset/216206>

[WebKit Commit Bot]

Re-opened since this is blocked by bug 171714

[Ryan Haddad]

(In reply to WebKit Commit Bot from comment #11)
> Re-opened since this is blocked by bug 171714

The rollout does appear to have stopped the LayoutTest crashes seen on the bots.

Crashlog and details in: https://bugs.webkit.org/show_bug.cgi?id=171705

[Sam Weinig]

Created attachment 309564 [details]
Patch

[Sam Weinig]

Committed r216641: <http://trac.webkit.org/changeset/216641>

[Sam Weinig]

Re-landed with fix to use ActiveDOMObject::stop, rather than ContextDestructionObserver::contextDestroyed as the override where we unregister the notification.