RESOLVED FIXED 171479
Allow WPT server to serve specific WebKit tests
https://bugs.webkit.org/show_bug.cgi?id=171479
Summary Allow WPT server to serve specific WebKit tests
youenn fablet
Reported 2017-04-29 11:06:07 PDT
Either we can add a specific directory within imported/w3c/web-platform-tests or we can add a mount point to WPT server directly.
Attachments
Patch (9.28 KB, patch)
2017-04-29 11:09 PDT, youenn fablet
no flags
Patch for landing (25.80 KB, patch)
2017-05-11 19:48 PDT, youenn fablet
no flags
Patch (25.80 KB, patch)
2017-05-11 19:52 PDT, youenn fablet
no flags
youenn fablet
Comment 1 2017-04-29 11:09:49 PDT
youenn fablet
Comment 2 2017-04-29 11:12:00 PDT
Gave it a try at tweaking our py infrastructure, pretty straightforward in fact. Sam, if you want to have a try at it... Maybe we want to move in that direction, I am not totally sure.
Ryosuke Niwa
Comment 3 2017-05-08 19:14:47 PDT
Comment on attachment 308673 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308673&action=review r=me provided we reach a consensus on webkit-dev for naming. > Tools/ChangeLog:9 > + It points to LayoutTests/wpt folder and is triggered on "/WebKit" urls. These directory names and the mounting point should probably be discussed on webkit-dev.
youenn fablet
Comment 4 2017-05-11 19:48:49 PDT
Created attachment 309851 [details] Patch for landing
Ryosuke Niwa
Comment 5 2017-05-11 19:49:42 PDT
Comment on attachment 309851 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=309851&action=review > Tools/ChangeLog:9 > + It points to LayoutTests/wpt folder and is triggered on "/WebKit" urls. Wait, you're adding this to LayoutTests/http/tests/wpt now, right?
youenn fablet
Comment 6 2017-05-11 19:51:22 PDT
(In reply to youenn fablet from comment #4) > Created attachment 309851 [details] > Patch for landing Made the following changes: - changed folder to http/wpt - moved some tests from http/tests/fetch to http/wpt/fetch to ensure they run well - added some unit py tests for the URI conversion part
youenn fablet
Comment 7 2017-05-11 19:51:41 PDT
(In reply to Ryosuke Niwa from comment #5) > Comment on attachment 309851 [details] > Patch for landing > > View in context: > https://bugs.webkit.org/attachment.cgi?id=309851&action=review > > > Tools/ChangeLog:9 > > + It points to LayoutTests/wpt folder and is triggered on "/WebKit" urls. > > Wait, you're adding this to LayoutTests/http/tests/wpt now, right? Ah, forgot to update the change log...
youenn fablet
Comment 8 2017-05-11 19:52:30 PDT
youenn fablet
Comment 9 2017-05-11 19:53:55 PDT
(In reply to youenn fablet from comment #7) > (In reply to Ryosuke Niwa from comment #5) > > Comment on attachment 309851 [details] > > Patch for landing > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=309851&action=review > > > > > Tools/ChangeLog:9 > > > + It points to LayoutTests/wpt folder and is triggered on "/WebKit" urls. > > > > Wait, you're adding this to LayoutTests/http/tests/wpt now, right? > > Ah, forgot to update the change log... I am adding to LayoutTests/http/wpt, LayoutTests/http/tests remains served by apache only.
WebKit Commit Bot
Comment 10 2017-05-11 20:16:23 PDT
Comment on attachment 309852 [details] Patch Clearing flags on attachment: 309852 Committed r216725: <http://trac.webkit.org/changeset/216725>
WebKit Commit Bot
Comment 11 2017-05-11 20:16:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.