Bug 171455 - Diagnostic logging of navigations is too verbose
Summary: Diagnostic logging of navigations is too verbose
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-04-28 15:29 PDT by Chris Dumez
Modified: 2017-04-28 20:55 PDT (History)
8 users (show)

See Also:


Attachments
Patch (8.91 KB, patch)
2017-04-28 16:03 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (8.91 KB, patch)
2017-04-28 16:07 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-04-28 15:29:31 PDT
Diagnostic logging of navigation is too verbose. We log things that are not actually user navigations (e.g. speculative loads, bookmark icon fetches, ...).
Comment 1 Chris Dumez 2017-04-28 15:30:04 PDT
<rdar://problem/31543815>
Comment 2 Chris Dumez 2017-04-28 16:03:39 PDT
Created attachment 308607 [details]
Patch
Comment 3 Chris Dumez 2017-04-28 16:07:15 PDT
Created attachment 308608 [details]
Patch
Comment 4 Andreas Kling 2017-04-28 20:26:28 PDT
Comment on attachment 308608 [details]
Patch

r=me. Nice approach for speculative loads that eventually become visible!
Comment 5 WebKit Commit Bot 2017-04-28 20:55:39 PDT
Comment on attachment 308608 [details]
Patch

Clearing flags on attachment: 308608

Committed r215969: <http://trac.webkit.org/changeset/215969>
Comment 6 WebKit Commit Bot 2017-04-28 20:55:41 PDT
All reviewed patches have been landed.  Closing bug.