Bug 171452 – Speedometer: Add an ES2015 (Babel + Webpack) TodoMVC implementation

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Addy Osmani]

As part of Speedometer 2.0 (https://bugs.webkit.org/show_bug.cgi?id=170513), add an ES2015 TodoMVC implementation that transpiles down to ES5 using Babel and Webpack. This is a variant on the implementation in https://bugs.webkit.org/show_bug.cgi?id=171448 which highlights a popular ES2015 -> ES5 transpiled code pattern very commonly seen in production today. Most developers are still doing complete ES2015 transpiles back to ES5 rather than everything their target browsers support. 

With this implementation we round up Speedometer's ability to track: vanilla ES5 code, vanilla ES2015 code and transpiled ES2015 code (if the other patches land).

[Addy Osmani]

Created attachment 308599 [details]
Patch

[Addy Osmani]

Created attachment 308630 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 308630 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308630&action=review

> PerformanceTests/ChangeLog:7
> +        Adds ES2015 Babel + Webpack TodoMVC implem

Again, we need a blank line before this.

> PerformanceTests/ChangeLog:11
> +        * Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.app.421eb6baca02218e985e.js: Added.

This file access localStorage. We probably want to avoid storing things into localStorage.
r- because of this.

> PerformanceTests/ChangeLog:12
> +        (o):

And remove these inline comments since we're just importing files.

[Addy Osmani]

Created attachment 309854 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 309854 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309854&action=review

> PerformanceTests/Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/store.js:23
> +    localStorage[name] = JSON.stringify(data)

I think we still have to get rid of these writes & reads from to localStorage.

[Addy Osmani]

Created attachment 309857 [details]
Patch

[Addy Osmani]

This revised version uses a localStorage shim (memory.js) that will only write to memory instead of localStorage or disk. Reads and writes should only occur from memory now.

[Ryosuke Niwa]

Comment on attachment 309857 [details]
Patch

Let's try CQ again now that git.webkit.org is back.

[WebKit Commit Bot]

Comment on attachment 309857 [details]
Patch

Clearing flags on attachment: 309857

Committed r216727: <http://trac.webkit.org/changeset/216727>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.