Bug 171436 - [Win] Set CMake args in build-webkit
Summary: [Win] Set CMake args in build-webkit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-28 10:24 PDT by Don Olmstead
Modified: 2017-05-10 03:04 PDT (History)
5 users (show)

See Also:

Attachments
Fix (1.14 KB, patch)
2017-04-28 10:35 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (1.09 KB, patch)
2017-05-05 15:22 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (1.09 KB, patch)
2017-05-09 16:45 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2017-04-28 10:24:07 PDT 
Currently any values passed in --cmakeargs to build-webkit are ignored on Windows builds.
Comment 1 Don Olmstead 2017-04-28 10:35:32 PDT 
Created attachment 308554 [details]
Fix
Comment 2 Per Arne Vollan 2017-05-03 23:34:20 PDT 
Comment on attachment 308554 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=308554&action=review

Looks good, but please remove the incorrect entries in the Changelog.

> Tools/ChangeLog:9
> +        (cMakeArgsFromFeatures): Deleted.

This function have not been deleted.

> Tools/ChangeLog:10
> +        (writeCongrats): Deleted.

Ditto.
Comment 3 Don Olmstead 2017-05-05 15:22:22 PDT 
Created attachment 309222 [details]
Patch

I just manually removed the lines. The script seems to be confused since its all in the root.
Comment 4 Per Arne Vollan 2017-05-06 00:07:37 PDT 
It seems the patch does not merge successfully on trunk.
Comment 5 Don Olmstead 2017-05-09 16:45:46 PDT 
Created attachment 309561 [details]
Patch
Comment 6 Per Arne Vollan 2017-05-10 02:35:29 PDT 
Comment on attachment 309561 [details]
Patch

R=me.
Comment 7 WebKit Commit Bot 2017-05-10 03:04:40 PDT 
Comment on attachment 309561 [details]
Patch

Clearing flags on attachment: 309561

Committed r216577: <http://trac.webkit.org/changeset/216577>
Comment 8 WebKit Commit Bot 2017-05-10 03:04:41 PDT 
All reviewed patches have been landed.  Closing bug.