Bug 171434 - [macOS] WebPlaybackControlsManager needs to know when the selected text or audio track changes
Summary: [macOS] WebPlaybackControlsManager needs to know when the selected text or au...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-04-28 10:00 PDT by Andy Estes
Modified: 2017-04-28 14:44 PDT (History)
9 users (show)

See Also:


Attachments
Patch (23.00 KB, patch)
2017-04-28 10:14 PDT, Andy Estes
no flags Details | Formatted Diff | Diff
Patch (28.59 KB, patch)
2017-04-28 12:55 PDT, Andy Estes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2017-04-28 10:00:07 PDT
[macOS] WebPlaybackControlsManager needs to know when the selected text or audio track changes
Comment 1 Andy Estes 2017-04-28 10:02:22 PDT
rdar://problem/31887922
Comment 2 Andy Estes 2017-04-28 10:14:10 PDT
Created attachment 308546 [details]
Patch
Comment 3 Andy Estes 2017-04-28 11:34:29 PDT
Comment on attachment 308546 [details]
Patch

Taking a different approach after talking to Jer and Eric.
Comment 4 Andy Estes 2017-04-28 12:55:22 PDT
Created attachment 308578 [details]
Patch
Comment 5 Eric Carlson 2017-04-28 13:03:47 PDT
Comment on attachment 308578 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308578&action=review

> Source/WebCore/platform/cocoa/WebPlaybackSessionModelMediaElement.mm:451
> +    if (offItem && !trackMenuItemSelected && displayMode == MediaControlsHost::forcedOnlyKeyword())

Nice catch!
Comment 6 WebKit Commit Bot 2017-04-28 14:44:19 PDT
Comment on attachment 308578 [details]
Patch

Clearing flags on attachment: 308578

Committed r215948: <http://trac.webkit.org/changeset/215948>
Comment 7 WebKit Commit Bot 2017-04-28 14:44:21 PDT
All reviewed patches have been landed.  Closing bug.