Bug 171433 - Adding a runtime flag specific to MediaDevices
Summary: Adding a runtime flag specific to MediaDevices
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on: 171730
Blocks:
  Show dependency tree / graph
 
Reported: 2017-04-28 08:59 PDT by youenn fablet
Modified: 2017-05-05 09:22 PDT (History)
4 users (show)

See Also:

Attachments
Patch (30.77 KB, patch)
2017-04-28 09:09 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (29.81 KB, patch)
2017-04-28 09:10 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (25.24 KB, patch)
2017-04-28 10:18 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-04-28 08:59:20 PDT 
This allows toggling MediaDevices and getUserMedia at runtime
Comment 1 youenn fablet 2017-04-28 09:09:21 PDT 
Created attachment 308536 [details]
Patch
Comment 2 youenn fablet 2017-04-28 09:10:12 PDT 
Created attachment 308537 [details]
Patch
Comment 3 youenn fablet 2017-04-28 10:18:47 PDT 
Created attachment 308549 [details]
Patch
Comment 4 Geoffrey Garen 2017-04-28 10:30:50 PDT 
Comment on attachment 308549 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308549&action=review

r=me

> Source/WebCore/ChangeLog:11
> +        Setting media devices runtime flag to false by default.

I think we want this preference to be true by default. Usually, we turn on all web platform features by default.
Comment 5 youenn fablet 2017-04-28 13:15:23 PDT 
(In reply to Geoffrey Garen from comment #4)
> Comment on attachment 308549 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=308549&action=review
> 
> r=me
> 
> > Source/WebCore/ChangeLog:11
> > +        Setting media devices runtime flag to false by default.
> 
> I think we want this preference to be true by default. Usually, we turn on
> all web platform features by default.

It is only enabled in DRT/WTR at the moment, not in WK1 and WK2 WebViews.
When it is fully ready, we should move to default=true.
Comment 6 WebKit Commit Bot 2017-04-28 13:42:44 PDT 
Comment on attachment 308549 [details]
Patch

Clearing flags on attachment: 308549

Committed r215939: <http://trac.webkit.org/changeset/215939>
Comment 7 WebKit Commit Bot 2017-04-28 13:42:45 PDT 
All reviewed patches have been landed.  Closing bug.