Bug 171431 – [GTK] Add GTK+ implementation of WebAutomationSession

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

Add platform dependent methods for GTK+ to synthesize events.

[Carlos Garcia Campos]

Created attachment 308528 [details]
Patch

This won't apply because it depends on two other patches.

[Blaze Burg]

Comment on attachment 308528 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308528&action=review

This looks good to me, though I cannot really assess bugs in usage of GTK platform specifics. You probably want a GTK reviewer too.

> Source/WebKit2/UIProcess/Automation/WebAutomationSession.h:231
> +    // GTK+ doesn't keep track of the active modifiers when using synthesizez events.

Typo: synthesized.

> Source/WebKit2/UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp:36
> +static inline unsigned modifiersToEventState(WebEvent::Modifiers modifiers)

These probably don't need to be 'inline'.

> Source/WebKit2/UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp:51
> +static inline unsigned mouseButtonToGdkButton(Inspector::Protocol::Automation::MouseButton button)

Ditto.

> Source/WebKit2/UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp:86
> +static void doMotionEvent(GtkWidget* widget, const WebCore::IntPoint& location, unsigned state)

Just FYI, on Mac we don't interpolate intermediate mouse positions. We might do so once the Actions API is implemented since it naturally specifies a duration for transitions.

[Carlos Garcia Campos]

Brian, this patch depends on bug #171107, could you cq+ the patch there when you are around to make sure it doesn't break anything on your side?

[Carlos Garcia Campos]

Committed r216114: <http://trac.webkit.org/changeset/216114>