RESOLVED FIXED 171412
Stop using legacy ClientRect / ClientRectList in Internals 
https://bugs.webkit.org/show_bug.cgi?id=171412
Summary Stop using legacy ClientRect / ClientRectList in Internals
Chris Dumez
Reported 2017-04-27 18:47:10 PDT
Stop using legacy ClientRect / ClientRectList in Internals.
Attachments
Patch (49.17 KB, patch)
2017-04-27 20:26 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (50.25 KB, patch)
2017-04-28 14:20 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (50.69 KB, patch)
2017-04-28 14:44 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (52.83 KB, patch)
2017-04-28 15:27 PDT, Chris Dumez 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-04-27 20:26:12 PDT
Created attachment 308495 [details] Patch
Chris Dumez
Comment 2 2017-04-28 14:20:00 PDT
Created attachment 308594 [details] Patch
Chris Dumez
Comment 3 2017-04-28 14:44:04 PDT
Created attachment 308598 [details] Patch
Chris Dumez
Comment 4 2017-04-28 15:27:23 PDT
Created attachment 308601 [details] Patch
Simon Fraser (smfr)
Comment 5 2017-04-28 16:26:42 PDT
Comment on attachment 308601 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308601&action=review > LayoutTests/ChangeLog:43 > +2017-04-28 Chris Dumez <cdumez@apple.com> > + > + Stop using legacy ClientRect / ClientRectList in Internals > + https://bugs.webkit.org/show_bug.cgi?id=171412 > + > + Reviewed by NOBODY (OOPS!). > + > + Rebaseline existing tests as DOMRect has more properties than ClientRect. > + > + * fast/visual-viewport/nonzoomed-rects-expected.txt: > + * fast/visual-viewport/rtl-nonzoomed-rects-expected.txt: > + * fast/visual-viewport/rtl-zoomed-rects-expected.txt: > + * fast/visual-viewport/rubberbanding-viewport-rects-expected.txt: > + * fast/visual-viewport/rubberbanding-viewport-rects-extended-background-expected.txt: > + * fast/visual-viewport/rubberbanding-viewport-rects-header-footer-expected.txt: > + * fast/visual-viewport/zoomed-fixed-expected.txt: > + * fast/visual-viewport/zoomed-fixed-header-and-footer-expected.txt: > + * fast/visual-viewport/zoomed-rects-expected.txt: > + * inspector/dom/hideHighlight-expected.txt: > + * inspector/dom/highlightQuad-expected.txt: > + * inspector/dom/highlightRect-expected.txt: Double changelog
Chris Dumez
Comment 6 2017-04-28 16:28:45 PDT
Committed r215956: <http://trac.webkit.org/changeset/215956>
Note You need to log in before you can comment on or make changes to this bug.