Bug 171412 - Stop using legacy ClientRect / ClientRectList in Internals
Summary: Stop using legacy ClientRect / ClientRectList in Internals
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 171393
Blocks: 171418
  Show dependency tree / graph
 
Reported: 2017-04-27 18:47 PDT by Chris Dumez
Modified: 2017-04-28 16:28 PDT (History)
6 users (show)

See Also:

Attachments
Patch (49.17 KB, patch)
2017-04-27 20:26 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (50.25 KB, patch)
2017-04-28 14:20 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (50.69 KB, patch)
2017-04-28 14:44 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (52.83 KB, patch)
2017-04-28 15:27 PDT, Chris Dumez 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-04-27 18:47:10 PDT 
Stop using legacy ClientRect / ClientRectList in Internals.
Comment 1 Chris Dumez 2017-04-27 20:26:12 PDT 
Created attachment 308495 [details]
Patch
Comment 2 Chris Dumez 2017-04-28 14:20:00 PDT 
Created attachment 308594 [details]
Patch
Comment 3 Chris Dumez 2017-04-28 14:44:04 PDT 
Created attachment 308598 [details]
Patch
Comment 4 Chris Dumez 2017-04-28 15:27:23 PDT 
Created attachment 308601 [details]
Patch
Comment 5 Simon Fraser (smfr) 2017-04-28 16:26:42 PDT 
Comment on attachment 308601 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308601&action=review

> LayoutTests/ChangeLog:43
> +2017-04-28  Chris Dumez  <cdumez@apple.com>
> +
> +        Stop using legacy ClientRect / ClientRectList in Internals
> +        https://bugs.webkit.org/show_bug.cgi?id=171412
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Rebaseline existing tests as DOMRect has more properties than ClientRect.
> +
> +        * fast/visual-viewport/nonzoomed-rects-expected.txt:
> +        * fast/visual-viewport/rtl-nonzoomed-rects-expected.txt:
> +        * fast/visual-viewport/rtl-zoomed-rects-expected.txt:
> +        * fast/visual-viewport/rubberbanding-viewport-rects-expected.txt:
> +        * fast/visual-viewport/rubberbanding-viewport-rects-extended-background-expected.txt:
> +        * fast/visual-viewport/rubberbanding-viewport-rects-header-footer-expected.txt:
> +        * fast/visual-viewport/zoomed-fixed-expected.txt:
> +        * fast/visual-viewport/zoomed-fixed-header-and-footer-expected.txt:
> +        * fast/visual-viewport/zoomed-rects-expected.txt:
> +        * inspector/dom/hideHighlight-expected.txt:
> +        * inspector/dom/highlightQuad-expected.txt:
> +        * inspector/dom/highlightRect-expected.txt:

Double changelog
Comment 6 Chris Dumez 2017-04-28 16:28:45 PDT 
Committed r215956: <http://trac.webkit.org/changeset/215956>