Bug 171404 – Fix some RELEASE_ASSERT failures caused by OutOfMemoryErrors.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

Patch coming.

[Radar WebKit Bug Importer]

<rdar://problem/31876178>

[Mark Lam]

Created attachment 308483 [details]
proposed patch.

[JF Bastien]

Comment on attachment 308483 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=308483&action=review

> Source/JavaScriptCore/runtime/JSCInlines.h:2
> + * Copyright (C) 2014-2017 Apple Inc. All rights reserved.

Is that legit? I though commas delimited a break, and dashes a range, so you're adding 2015 in there as a date where work was performed along with 2017.

> Source/JavaScriptCore/runtime/JSCellInlines.h:145
> +template<typename T, bool assertOnFailure, bool takesDeferralContext>

I like having enum classes instead of bools.

> Source/JavaScriptCore/runtime/JSGlobalObject.h:3
> + *  Copyright (C) 2007-2017 Apple Inc. All rights reserved.

Ditto.

[Mark Lam]

Comment on attachment 308483 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=308483&action=review

>> Source/JavaScriptCore/runtime/JSCInlines.h:2
>> + * Copyright (C) 2014-2017 Apple Inc. All rights reserved.
> 
> Is that legit? I though commas delimited a break, and dashes a range, so you're adding 2015 in there as a date where work was performed along with 2017.

Yes, we've been told to do it this way now.  My understanding of it is that we've always held the copyright for the file even if we didn't modify it in those tween years.

>> Source/JavaScriptCore/runtime/JSCellInlines.h:145
>> +template<typename T, bool assertOnFailure, bool takesDeferralContext>
> 
> I like having enum classes instead of bools.

Will apply enum classes to placate you.

[Mark Lam]

Created attachment 308484 [details]
proposed patch.

[Saam Barati]

Comment on attachment 308484 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=308484&action=review

> Source/JavaScriptCore/runtime/JSCellInlines.h:146
> +template<typename T, AllocationFailureMode mode, GCDeferralContextArgPresense deferralContextArgPresence>
> +void* tryAllocateCellHelper(Heap& heap, GCDeferralContext* deferralContext, size_t size)

I would mark this as ALWAYS_INLINE

> Source/JavaScriptCore/runtime/JSFixedArray.h:47
>      ALWAYS_INLINE static JSFixedArray* createFromArray(ExecState* exec, VM& vm, JSArray* array)
>      {

The caller of this from operationMaterializeObjectInOSR is not OK w/ returning nullptr here. Please fix to make that release assert.

[Mark Lam]

Comment on attachment 308484 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=308484&action=review

Thanks for the review.

>> Source/JavaScriptCore/runtime/JSCellInlines.h:146
>> +void* tryAllocateCellHelper(Heap& heap, GCDeferralContext* deferralContext, size_t size)
> 
> I would mark this as ALWAYS_INLINE

Fixed.

>> Source/JavaScriptCore/runtime/JSFixedArray.h:47
>>      {
> 
> The caller of this from operationMaterializeObjectInOSR is not OK w/ returning nullptr here. Please fix to make that release assert.

I did.  See above diff in FTLOperations.cpp.

[Mark Lam]

Landed in r215919: <http://trac.webkit.org/r215919>.

[Saam Barati]

Comment on attachment 308484 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=308484&action=review

>>> Source/JavaScriptCore/runtime/JSFixedArray.h:47
>>>      {
>> 
>> The caller of this from operationMaterializeObjectInOSR is not OK w/ returning nullptr here. Please fix to make that release assert.
> 
> I did.  See above diff in FTLOperations.cpp.

👍🏽. I missed that when reading the code.