Bug 171402 – Web Inspector: RTL: inherit system layout direction by default

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

Ready, set, file bugs!

[Blaze Burg]

<rdar://problem/30753626>

[Blaze Burg]

Created attachment 308473 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 308473 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308473&action=review

r=me

> Source/WebInspectorUI/UserInterface/Base/Setting.js:115
> -    // FIXME: change initial value to 'system' once we are happy with RTL support.
> -    // This will cause Web Inspector to use the system user interface layout direction.
> -    layoutDirection: new WebInspector.Setting("layout-direction", "ltr"),
> +    layoutDirectionOverride: new WebInspector.Setting("layout-direction-override", "system"),

I realize the storage name needs to change in order for us to get the new default value of "system" going forward.

However I think WebInspector.settings.layoutDirection is way better than WebInspector.settings.layoutDirectionOverride. I suggest we keep that.

This brings to light that in the future we should name settings that are in experimental stages with a storage name "...-experimental" so that when we turn it on by default and rename it we can get the better name when it graduates!

[Blaze Burg]

Created attachment 308474 [details]
Patch

[Blaze Burg]

(In reply to Joseph Pecoraro from comment #3)
> Comment on attachment 308473 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=308473&action=review
> 
> r=me
> 
> > Source/WebInspectorUI/UserInterface/Base/Setting.js:115
> > -    // FIXME: change initial value to 'system' once we are happy with RTL support.
> > -    // This will cause Web Inspector to use the system user interface layout direction.
> > -    layoutDirection: new WebInspector.Setting("layout-direction", "ltr"),
> > +    layoutDirectionOverride: new WebInspector.Setting("layout-direction-override", "system"),
> 
> I realize the storage name needs to change in order for us to get the new
> default value of "system" going forward.
> 
> However I think WebInspector.settings.layoutDirection is way better than
> WebInspector.settings.layoutDirectionOverride. I suggest we keep that.
> 
> This brings to light that in the future we should name settings that are in
> experimental stages with a storage name "...-experimental" so that when we
> turn it on by default and rename it we can get the better name when it
> graduates!

OK!

[Blaze Burg]

Committed r215906: <http://trac.webkit.org/changeset/215906>

[Matt Baker]

(In reply to Joseph Pecoraro from comment #3)
> This brings to light that in the future we should name settings that are in
> experimental stages with a storage name "...-experimental" so that when we
> turn it on by default and rename it we can get the better name when it
> graduates!

We could either:

1) Create an ExperimentalSetting class which adds the storage name.
2) Add an `experimental` property (default false) to Setting which does the same thing.

[Daniel Bates]

Comment on attachment 308474 [details]
Patch

Clearing review flag as this patch was landed per comment 6.