RESOLVED FIXED 171401
Web Inspector: Remove unused ToggleControlToolbarItem.js 
https://bugs.webkit.org/show_bug.cgi?id=171401
Summary Web Inspector: Remove unused ToggleControlToolbarItem.js
Nikita Vasilyev
Reported 2017-04-27 16:14:15 PDT
It isn't used anywhere in our code. I searched and the only mentions I found were in Changelog files: Source ⮀ack -Q 'ToggleControlToolbarItem' WebInspectorUI/ChangeLog-2013-06-11 519: * UserInterface/ToggleControlToolbarItem.js: 3431: ToggleControlToolbarItem regenerates its images every time 'toggled' is set, even 5763: (WebInspector.contentLoaded): Use ToggleControlToolbarItem for undock button. 15393: * UserInterface/ToggleControlToolbarItem.js: Added. 15394: (WebInspector.ToggleControlToolbarItem): WebInspectorUI/ChangeLog-2015-11-21 8792: * UserInterface/Views/ToggleControlToolbarItem.js: 8793: (WebInspector.ToggleControlToolbarItem): 8794: (WebInspector.ToggleControlToolbarItem.prototype.get additionalClassNames):
Attachments
Patch (3.41 KB, patch)
2017-04-27 16:19 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikita Vasilyev
Comment 1 2017-04-27 16:19:20 PDT
Created attachment 308471 [details] Patch
Joseph Pecoraro
Comment 2 2017-04-27 18:38:20 PDT
Comment on attachment 308471 [details] Patch r=me
WebKit Commit Bot
Comment 3 2017-04-27 19:07:43 PDT
Comment on attachment 308471 [details] Patch Clearing flags on attachment: 308471 Committed r215915: <http://trac.webkit.org/changeset/215915>
WebKit Commit Bot
Comment 4 2017-04-27 19:07:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.