WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
171400
[ARES6] Active Running Test indicator (dot) is too subtle
https://bugs.webkit.org/show_bug.cgi?id=171400
Summary
[ARES6] Active Running Test indicator (dot) is too subtle
Joseph Pecoraro
Reported
2017-04-27 15:58:18 PDT
[ARES6] Active Running Test indicator (dot) is too subtle - The small gold dot is too subtle - This is especially significant for those unfamiliar with the page. Since results update again and again for later runs, the dot is too subtle to indicate a test is being run again Possible improvements: - Alongside the dot, update the title text of a test when it is active (white, gold, or some contrasting color)
Attachments
[IMAGE] White Title
(31.94 KB, image/png)
2017-04-28 19:38 PDT
,
Joseph Pecoraro
no flags
Details
[IMAGE] Invert Title
(31.95 KB, image/png)
2017-04-28 19:38 PDT
,
Joseph Pecoraro
no flags
Details
[PATCH] White Title
(9.54 KB, patch)
2017-04-28 19:40 PDT
,
Joseph Pecoraro
no flags
Details
Formatted Diff
Diff
Patch
(3.01 KB, patch)
2017-05-04 16:10 PDT
,
Jon Davis
no flags
Details
Formatted Diff
Diff
[IMAGE] Proposed
(31.54 KB, image/png)
2017-05-04 16:24 PDT
,
Joseph Pecoraro
no flags
Details
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Saam Barati
Comment 1
2017-04-27 16:35:07 PDT
I'm a fan of what JetStream does here by highlighting the background text of the test running.
Saam Barati
Comment 2
2017-04-27 16:35:43 PDT
FWIW, I've heard from many people that they didn't understand what the dot was for, or didn't even notice the dot was there.
Joseph Pecoraro
Comment 3
2017-04-28 19:38:00 PDT
Created
attachment 308652
[details]
[IMAGE] White Title
Joseph Pecoraro
Comment 4
2017-04-28 19:38:14 PDT
Created
attachment 308653
[details]
[IMAGE] Invert Title
Joseph Pecoraro
Comment 5
2017-04-28 19:40:40 PDT
Created
attachment 308654
[details]
[PATCH] White Title I rather like just having a white title. It makes it immediately obvious. Here is a starter patch if you want to go that route. .test.running h2 { color: #ffffff; } The invert was something like: .test.running h2 { background-color: #E7B135; color: #2C2C3C; } The page only used a few colors though so I didn't want to stray. You probably have better ideas. =)
Jon Davis
Comment 6
2017-05-04 16:10:48 PDT
Created
attachment 309112
[details]
Patch
Joseph Pecoraro
Comment 7
2017-05-04 16:24:01 PDT
Created
attachment 309113
[details]
[IMAGE] Proposed Looks good to me.
Joseph Pecoraro
Comment 8
2017-05-04 16:25:55 PDT
Comment on
attachment 309112
[details]
Patch r=me
WebKit Commit Bot
Comment 9
2017-05-09 14:02:01 PDT
Comment on
attachment 309112
[details]
Patch Clearing flags on attachment: 309112 Committed
r216538
: <
http://trac.webkit.org/changeset/216538
>
WebKit Commit Bot
Comment 10
2017-05-09 14:02:03 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug