Bug 171392 – testWasmBoundsCheck and testCallFunctionWithHellaArguments is broken in testb3

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

...

[Radar WebKit Bug Importer]

<rdar://problem/31872222>

[Saam Barati]

*** Bug 171767 has been marked as a duplicate of this bug. ***

[Saam Barati]

Created attachment 309438 [details]
patch

[Build Bot]

Attachment 309438 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/b3/testb3.cpp:10406:  l is incorrectly named. Don't use the single letter 'l' as an identifier name.  [readability/naming] [4]
ERROR: Source/JavaScriptCore/b3/testb3.cpp:10434:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/JavaScriptCore/b3/testb3.cpp:10453:  Consider using CHECK_EQ instead of CHECK(a == b)  [readability/check] [2]
ERROR: Source/JavaScriptCore/b3/testb3.cpp:10455:  Consider using CHECK_EQ instead of CHECK(a == b)  [readability/check] [2]
ERROR: Source/JavaScriptCore/b3/testb3.cpp:10457:  Consider using CHECK_EQ instead of CHECK(a == b)  [readability/check] [2]
ERROR: Source/JavaScriptCore/b3/testb3.cpp:10459:  Consider using CHECK_EQ instead of CHECK(a == b)  [readability/check] [2]
Total errors found: 6 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Keith Miller]

Comment on attachment 309438 [details]
patch

r=me. Wow, that's a lot of failing ARM tests :(

[Saam Barati]

(In reply to Keith Miller from comment #5)
> Comment on attachment 309438 [details]
> patch
> 
> r=me. Wow, that's a lot of failing ARM tests :(

Yeah. There appeared to be a lot of repetition in the failures, but I didn't investigate any of them.

[WebKit Commit Bot]

Comment on attachment 309438 [details]
patch

Clearing flags on attachment: 309438

Committed r216468: <http://trac.webkit.org/changeset/216468>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.