Bug 171392 - testWasmBoundsCheck and testCallFunctionWithHellaArguments is broken in testb3
Summary: testWasmBoundsCheck and testCallFunctionWithHellaArguments is broken in testb3
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
: 171767 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-04-27 13:59 PDT by Saam Barati
Modified: 2017-05-08 18:35 PDT (History)
13 users (show)

See Also:


Attachments
patch (117.92 KB, patch)
2017-05-08 16:25 PDT, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2017-04-27 13:59:04 PDT
...
Comment 1 Radar WebKit Bug Importer 2017-04-27 14:00:55 PDT
<rdar://problem/31872222>
Comment 2 Saam Barati 2017-05-08 14:24:11 PDT
*** Bug 171767 has been marked as a duplicate of this bug. ***
Comment 3 Saam Barati 2017-05-08 16:25:14 PDT
Created attachment 309438 [details]
patch
Comment 4 Build Bot 2017-05-08 16:28:15 PDT
Attachment 309438 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/b3/testb3.cpp:10406:  l is incorrectly named. Don't use the single letter 'l' as an identifier name.  [readability/naming] [4]
ERROR: Source/JavaScriptCore/b3/testb3.cpp:10434:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/JavaScriptCore/b3/testb3.cpp:10453:  Consider using CHECK_EQ instead of CHECK(a == b)  [readability/check] [2]
ERROR: Source/JavaScriptCore/b3/testb3.cpp:10455:  Consider using CHECK_EQ instead of CHECK(a == b)  [readability/check] [2]
ERROR: Source/JavaScriptCore/b3/testb3.cpp:10457:  Consider using CHECK_EQ instead of CHECK(a == b)  [readability/check] [2]
ERROR: Source/JavaScriptCore/b3/testb3.cpp:10459:  Consider using CHECK_EQ instead of CHECK(a == b)  [readability/check] [2]
Total errors found: 6 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Keith Miller 2017-05-08 16:30:44 PDT
Comment on attachment 309438 [details]
patch

r=me. Wow, that's a lot of failing ARM tests :(
Comment 6 Saam Barati 2017-05-08 16:31:48 PDT
(In reply to Keith Miller from comment #5)
> Comment on attachment 309438 [details]
> patch
> 
> r=me. Wow, that's a lot of failing ARM tests :(

Yeah. There appeared to be a lot of repetition in the failures, but I didn't investigate any of them.
Comment 7 WebKit Commit Bot 2017-05-08 18:35:25 PDT
Comment on attachment 309438 [details]
patch

Clearing flags on attachment: 309438

Committed r216468: <http://trac.webkit.org/changeset/216468>
Comment 8 WebKit Commit Bot 2017-05-08 18:35:27 PDT
All reviewed patches have been landed.  Closing bug.