Bug 171382 - Restore some caching functionality that got accidentally removed when doing Wasm PIC patches
Summary: Restore some caching functionality that got accidentally removed when doing W...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-27 11:00 PDT by Saam Barati
Modified: 2017-04-27 13:58 PDT (History)
11 users (show)

See Also:


Attachments
patch (4.55 KB, patch)
2017-04-27 12:06 PDT, Saam Barati
keith_miller: review+
Details | Formatted Diff | Diff
patch for landing (4.54 KB, patch)
2017-04-27 12:10 PDT, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2017-04-27 11:00:47 PDT
I moved some stuff to Wasm::CodeBlock, and forgot to take it out of JSWebAssemblyCodeBlock, when doing PIC work.
Comment 1 Saam Barati 2017-04-27 12:06:17 PDT
Created attachment 308423 [details]
patch
Comment 2 Keith Miller 2017-04-27 12:08:54 PDT
Comment on attachment 308423 [details]
patch

r=me.
Comment 3 Saam Barati 2017-04-27 12:10:43 PDT
Created attachment 308424 [details]
patch for landing
Comment 4 WebKit Commit Bot 2017-04-27 13:58:07 PDT
Comment on attachment 308424 [details]
patch for landing

Clearing flags on attachment: 308424

Committed r215891: <http://trac.webkit.org/changeset/215891>
Comment 5 WebKit Commit Bot 2017-04-27 13:58:08 PDT
All reviewed patches have been landed.  Closing bug.