Bug 171372 – Move UUID from WebCore/platform to WTF

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Template Framework

[Carlos Garcia Campos]

UUID only contains createCanonicalUUIDString() that is platform independent and doesn't depend on anything from WebCore, only from WTF. I plan to use it in the GTK+ WebDriver implementation that doesn't link to WebCore.

[Carlos Garcia Campos]

Created attachment 308386 [details]
Patch

[Michael Catanzaro]

Every bot is red

[Carlos Garcia Campos]

(In reply to Michael Catanzaro from comment #2)
> Every bot is red

No, style and bindings are green! :-)

[Carlos Garcia Campos]

Created attachment 308391 [details]
Updated patch

I forgot to add the files to WTF makefile :-P

[Michael Catanzaro]

Comment on attachment 308391 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308391&action=review

r=me if it passes EWS

> Tools/WebKitTestRunner/TestController.cpp:-1880
> -static String createCanonicalUUIDString()

Was this unused?

[Carlos Garcia Campos]

(In reply to Michael Catanzaro from comment #5)
> Comment on attachment 308391 [details]
> Updated patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=308391&action=review
> 
> r=me if it passes EWS
> 
> > Tools/WebKitTestRunner/TestController.cpp:-1880
> > -static String createCanonicalUUIDString()
> 
> Was this unused?

No, it was duplicated, defined as static but alos included from WebCore, so this one was actually used because it was called with no namespace, but there's no reason to include the WebCore, WTF one and duplicate the implementation there.

[Alex Christensen]

Comment on attachment 308391 [details]
Updated patch

cool

[WebKit Commit Bot]

Comment on attachment 308391 [details]
Updated patch

Rejecting attachment 308391 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 308391, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
n.cpp
patching file Source/WebKit2/UIProcess/gtk/WaylandCompositor.cpp
patching file Source/WebKit2/WebProcess/Automation/WebAutomationSessionProxy.cpp
patching file Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/WebKitTestRunner/TestController.cpp

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Michael Catanzaro']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/3624408

[Carlos Garcia Campos]

Committed r215922: <http://trac.webkit.org/changeset/215922>