WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
171370
Text gets cut off when bailing out of simple line layout with widows.
https://bugs.webkit.org/show_bug.cgi?id=171370
Summary
Text gets cut off when bailing out of simple line layout with widows.
zalan
Reported
2017-04-27 02:49:47 PDT
rdar://problem/31563414
Attachments
Patch
(4.48 KB, patch)
2017-04-27 02:56 PDT
,
zalan
no flags
Details
Formatted Diff
Diff
Patch
(4.53 KB, patch)
2017-04-27 03:08 PDT
,
zalan
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
zalan
Comment 1
2017-04-27 02:56:19 PDT
Created
attachment 308365
[details]
Patch
Antti Koivisto
Comment 2
2017-04-27 03:01:14 PDT
Comment on
attachment 308365
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=308365&action=review
> Source/WebCore/rendering/RenderBlockFlow.cpp:3737 > + if (shouldBreakAtLineToAvoidWidow()) > + layoutLineBoxes(relayoutChildren, repaintLogicalTop, repaintLogicalBottom);
Maybe add a comment here about how this matches relayoutToAvoidWidows?
zalan
Comment 3
2017-04-27 03:08:40 PDT
Created
attachment 308368
[details]
Patch
WebKit Commit Bot
Comment 4
2017-04-27 04:02:12 PDT
Comment on
attachment 308368
[details]
Patch Clearing flags on attachment: 308368 Committed
r215861
: <
http://trac.webkit.org/changeset/215861
>
WebKit Commit Bot
Comment 5
2017-04-27 04:02:14 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug