Bug 171370 - Text gets cut off when bailing out of simple line layout with widows.
Summary: Text gets cut off when bailing out of simple line layout with widows.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-04-27 02:49 PDT by zalan
Modified: 2017-04-27 04:02 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.48 KB, patch)
2017-04-27 02:56 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (4.53 KB, patch)
2017-04-27 03:08 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-04-27 02:49:47 PDT 
rdar://problem/31563414
Comment 1 zalan 2017-04-27 02:56:19 PDT 
Created attachment 308365 [details]
Patch
Comment 2 Antti Koivisto 2017-04-27 03:01:14 PDT 
Comment on attachment 308365 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308365&action=review

> Source/WebCore/rendering/RenderBlockFlow.cpp:3737
> +        if (shouldBreakAtLineToAvoidWidow())
> +            layoutLineBoxes(relayoutChildren, repaintLogicalTop, repaintLogicalBottom);

Maybe add a comment here about how this matches relayoutToAvoidWidows?
Comment 3 zalan 2017-04-27 03:08:40 PDT 
Created attachment 308368 [details]
Patch
Comment 4 WebKit Commit Bot 2017-04-27 04:02:12 PDT 
Comment on attachment 308368 [details]
Patch

Clearing flags on attachment: 308368

Committed r215861: <http://trac.webkit.org/changeset/215861>
Comment 5 WebKit Commit Bot 2017-04-27 04:02:14 PDT 
All reviewed patches have been landed.  Closing bug.