Bug 171365 – Update NetworkStorageSession to support multiple persistent sessions and explicitly set cookie storages

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Update NetworkStorageSession to support multiple persistent sessions and explicitly set cookie storages

Also a little WK2 NetworkSessionCocoa update based on this.

[Brady Eidson]

Created attachment 308337 [details]
Patch

[Brady Eidson]

Created attachment 308354 [details]
Patch

[Brady Eidson]

Created attachment 308357 [details]
Patch

[Alex Christensen]

Comment on attachment 308354 [details]
Patch

Oh boy

[Brady Eidson]

Created attachment 308395 [details]
Patch

[Brady Eidson]

(In reply to Alex Christensen from comment #4)
> Comment on attachment 308354 [details]
> Patch
> 
> Oh boy

It's on like Donkey Kong.

[Andy Estes]

Comment on attachment 308395 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308395&action=review

> Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:65
> +    auto sharedCookieStorage = adoptCF(_CFHTTPCookieStorageGetDefault(kCFAllocatorDefault));

Over IRC we confirmed that what _CFHTTPCookieStorageGetDefault() returns shouldn't be adopted.

> Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:72
> +NetworkStorageSession::NetworkStorageSession(SessionID sessionID, RetainPtr<CFURLStorageSessionRef> platformSession, RetainPtr<CFHTTPCookieStorageRef> platformCookieStorage)

These RetainPtrs could probably be rvalue references.

[Brady Eidson]

Created attachment 308407 [details]
Patch

[Brady Eidson]

Will CQ+ after I finish running API tests locally (damn you EWS!)

[WebKit Commit Bot]

Comment on attachment 308407 [details]
Patch

Clearing flags on attachment: 308407

Committed r215883: <http://trac.webkit.org/changeset/215883>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Konstantin Tokarev]

Should SessionID::isEphemeral() be changed now?

[Alex Christensen]

(In reply to Konstantin Tokarev from comment #12)
> Should SessionID::isEphemeral() be changed now?
That'll be done in https://bugs.webkit.org/show_bug.cgi?id=171367

[Alex Christensen]

http://trac.webkit.org/r215928

[Radar WebKit Bug Importer]

<rdar://problem/31891415>