Bug 171350 – [WebCrypto] Add an api test for testing wrapping/unwrapping serialized crypto keys

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Jiewen Tan]

Add an api test for testing wrapping/unwrapping serialized crypto keys.

[Jiewen Tan]

<rdar://problem/28600836>

[Jiewen Tan]

Created attachment 308303 [details]
Patch

[Brent Fulgham]

Comment on attachment 308303 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308303&action=review

This looks good, but I think your test case is wrong in the openRequest.onerror handler. Can you please fix before landing?

> Tools/TestWebKitAPI/Tests/WebKit2/navigation-client-default-crypto.html:49
> +        finishJSTest();

There are no definitions for "testFailed" or "finishJSTest" in TestWebKitAPI -- I'm surprised this doesn't create an error when you run.

Please remove these lines and switch to "alert("FAIL")" or something for these failure case.

[Jiewen Tan]

Comment on attachment 308303 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308303&action=review

Thanks Brent for r+ the patch.

>> Tools/TestWebKitAPI/Tests/WebKit2/navigation-client-default-crypto.html:49
>> +        finishJSTest();
> 
> There are no definitions for "testFailed" or "finishJSTest" in TestWebKitAPI -- I'm surprised this doesn't create an error when you run.
> 
> Please remove these lines and switch to "alert("FAIL")" or something for these failure case.

I think that's because those code paths are never executed.

[Jiewen Tan]

Created attachment 308939 [details]
Patch for landing

[Jiewen Tan]

Committed r216157: <http://trac.webkit.org/changeset/216157>