Bug 171347 - REGRESSION(r215686): This change caused assertion failures in existing LayoutTests (Requested by mlewis13 on #webkit).
Summary: REGRESSION(r215686): This change caused assertion failures in existing Layout...
Status: RESOLVED DUPLICATE of bug 171340
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Commit Bot
URL:
Keywords:
Depends on:
Blocks: 170956
  Show dependency treegraph
 
Reported: 2017-04-26 16:02 PDT by WebKit Commit Bot
Modified: 2017-04-26 17:15 PDT (History)
4 users (show)

See Also:


Attachments
ROLLOUT of r215686 (99.46 KB, patch)
2017-04-26 16:03 PDT, WebKit Commit Bot
achristensen: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Commit Bot 2017-04-26 16:02:56 PDT
http://trac.webkit.org/changeset/215686 broke the build:
This change caused assertion failures in existing LayoutTests (Requested by mlewis13 on #webkit).

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2017-04-26 16:03:17 PDT
Created attachment 308298 [details]
ROLLOUT of r215686

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Alex Christensen 2017-04-26 16:04:25 PDT
Comment on attachment 308298 [details]
ROLLOUT of r215686

We should fix the assertion failures.
Comment 3 Ryan Haddad 2017-04-26 16:06:42 PDT
(In reply to Alex Christensen from comment #2)
> Comment on attachment 308298 [details]
> ROLLOUT of r215686
> 
> We should fix the assertion failures.

Alright, we will wait for a fix. Thanks Alex!
Comment 4 Alexey Proskuryakov 2017-04-26 16:53:44 PDT
Alex, can you elaborate? Why is it so important to put up with assertions for now? What is the ETA for a fix?

Rolling back is the default answer to regressions, and waiting should be a rare exception.
Comment 5 Alex Christensen 2017-04-26 17:15:46 PDT
Problem fixed in https://bugs.webkit.org/show_bug.cgi?id=171340

*** This bug has been marked as a duplicate of bug 171340 ***