Bug 171344 - Audit and fix incorrect uses of JSArray::tryCreateForInitializationPrivate().
Summary: Audit and fix incorrect uses of JSArray::tryCreateForInitializationPrivate().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-04-26 15:03 PDT by Mark Lam
Modified: 2017-04-27 12:25 PDT (History)
7 users (show)

See Also:


Attachments
work in progress. (46.72 KB, patch)
2017-04-26 23:17 PDT, Mark Lam
no flags Details | Formatted Diff | Diff
work in progress. (59.56 KB, patch)
2017-04-26 23:42 PDT, Mark Lam
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews114 for mac-elcapitan (1.80 MB, application/zip)
2017-04-27 01:08 PDT, Build Bot
no flags Details
proposed patch. (67.51 KB, patch)
2017-04-27 10:42 PDT, Mark Lam
fpizlo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2017-04-26 15:03:47 PDT
Patch coming.
Comment 1 Mark Lam 2017-04-26 15:04:06 PDT
<rdar://problem/31352667>
Comment 2 Mark Lam 2017-04-26 23:17:41 PDT
Created attachment 308347 [details]
work in progress.
Comment 3 Mark Lam 2017-04-26 23:42:42 PDT
Created attachment 308351 [details]
work in progress.
Comment 4 Build Bot 2017-04-27 01:08:13 PDT
Comment on attachment 308351 [details]
work in progress.

Attachment 308351 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3617461

New failing tests:
js/kde/Array.html
Comment 5 Build Bot 2017-04-27 01:08:15 PDT
Created attachment 308363 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 Mark Lam 2017-04-27 10:42:38 PDT
Created attachment 308408 [details]
proposed patch.
Comment 7 Filip Pizlo 2017-04-27 12:17:28 PDT
Comment on attachment 308408 [details]
proposed patch.

This is really cool!
Comment 8 Mark Lam 2017-04-27 12:23:30 PDT
Comment on attachment 308408 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=308408&action=review

> Source/JavaScriptCore/ChangeLog:24
> +           are meant for clients of WebKit.  In this case, we intend for use of this API

There's a typo here.  I meant to say "are not meant for clients of WebKit".  Will fix before landing.
Comment 9 Mark Lam 2017-04-27 12:25:36 PDT
Thanks for the review.  Landed in r215885: <http://trac.webkit.org/r215885>.