Bug 171342 - Speedometer: Update the Ember.js TodoMVC to a more recent version
Summary: Speedometer: Update the Ember.js TodoMVC to a more recent version
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Addy Osmani
URL:
Keywords:
Depends on:
Blocks: 170513
  Show dependency tree / graph
 
Reported: 2017-04-26 14:06 PDT by Addy Osmani
Modified: 2017-05-11 23:34 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.48 MB, patch)
2017-04-26 14:16 PDT, Addy Osmani 		no flags Details | Formatted Diff | Diff
Patch (4.08 MB, patch)
2017-05-11 22:44 PDT, Addy Osmani 		no flags Details | Formatted Diff | Diff
Patch (4.08 MB, patch)
2017-05-11 22:48 PDT, Addy Osmani 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Addy Osmani 2017-04-26 14:06:49 PDT 
As part of Speedometer 2.0 (https://bugs.webkit.org/show_bug.cgi?id=170513), the Ember.js implementation of TodoMVC needs to be updated to a more recent version. This would update it to a rewrite using ember-cli (the now de facto way of creating Ember apps) and also bump the Ember version used.
Comment 1 Addy Osmani 2017-04-26 14:16:46 PDT 
Created attachment 308283 [details]
Patch
Comment 2 Ryosuke Niwa 2017-05-08 23:20:27 PDT 
As usual, please add a blink line between Reviewed by and the change log description,
and remove these inline comments as they don't add any value since we're simply importing files.

We should also probably comment out setItem in resources/todomvc/architecture-examples/emberjs/source/app/services/repo.js.
Is todomvc-fdd2c48cf675753de4a79c857343e23f.js used? If so, that also calls localStorage.setItem.
We might need to override window.localStorage in prepare function instead if the minimized version calls setItem.
Comment 3 Addy Osmani 2017-05-11 22:44:33 PDT 
Created attachment 309870 [details]
Patch
Comment 4 Addy Osmani 2017-05-11 22:48:01 PDT 
Created attachment 309871 [details]
Patch
Comment 5 Addy Osmani 2017-05-11 22:51:42 PDT 
I've added an in-memory localStorage shim that doesn't persist any data to the implementation. I've also added a blank line and trimmed down the inline comments per the other patches.
Comment 6 WebKit Commit Bot 2017-05-11 23:34:18 PDT 
Comment on attachment 309871 [details]
Patch

Clearing flags on attachment: 309871

Committed r216735: <http://trac.webkit.org/changeset/216735>
Comment 7 WebKit Commit Bot 2017-05-11 23:34:19 PDT 
All reviewed patches have been landed.  Closing bug.