WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
171329
Speedometer: Add a React + Redux TodoMVC implementation
https://bugs.webkit.org/show_bug.cgi?id=171329
Summary
Speedometer: Add a React + Redux TodoMVC implementation
Addy Osmani
Reported
2017-04-26 09:24:06 PDT
As part of Speedometer 2.0 (
https://bugs.webkit.org/show_bug.cgi?id=170513
), this tracks adding a TodoMVC implementation for React with Redux. Redux is popular with libraries like React because it lets you describe UI as a function of state, and Redux emits state updates in response to actions. Applications built using Redux demonstrate sufficiently different patterns to how a normal React app is crafted that it was worth including.
Attachments
Patch
(444.56 KB, patch)
2017-04-26 09:42 PDT
,
Addy Osmani
no flags
Details
Formatted Diff
Diff
Patch
(437.93 KB, patch)
2017-05-11 18:49 PDT
,
Addy Osmani
no flags
Details
Formatted Diff
Diff
Patch
(437.78 KB, patch)
2017-05-11 19:46 PDT
,
Addy Osmani
no flags
Details
Formatted Diff
Diff
Patch
(437.98 KB, patch)
2017-05-11 20:35 PDT
,
Addy Osmani
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Addy Osmani
Comment 1
2017-04-26 09:42:20 PDT
Created
attachment 308260
[details]
Patch
Addy Osmani
Comment 2
2017-05-11 18:49:46 PDT
Created
attachment 309845
[details]
Patch
Addy Osmani
Comment 3
2017-05-11 18:51:09 PDT
Per the other patches, I've made sure to add an extra line before the patch title and remove extraneous comments from the changelog.
Ryosuke Niwa
Comment 4
2017-05-11 19:15:13 PDT
It looks like this patch doesn't apply on ToT. Would you mind rebasing against trunk?
Addy Osmani
Comment 5
2017-05-11 19:46:32 PDT
Created
attachment 309850
[details]
Patch
Addy Osmani
Comment 6
2017-05-11 19:47:04 PDT
Re-submitted after rebasing against trunk. Let's see if it needs another round of work.
Addy Osmani
Comment 7
2017-05-11 20:35:18 PDT
Created
attachment 309859
[details]
Patch
WebKit Commit Bot
Comment 8
2017-05-11 22:50:37 PDT
Comment on
attachment 309859
[details]
Patch Clearing flags on attachment: 309859 Committed
r216732
: <
http://trac.webkit.org/changeset/216732
>
WebKit Commit Bot
Comment 9
2017-05-11 22:50:38 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug