Bug 171328 - [macOS] Add picture-in-picture support to WebPlaybackControlsManager
Summary: [macOS] Add picture-in-picture support to WebPlaybackControlsManager
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-04-26 09:18 PDT by Andy Estes
Modified: 2017-04-26 10:51 PDT (History)
10 users (show)

See Also:


Attachments
Patch (16.17 KB, patch)
2017-04-26 09:30 PDT, Andy Estes
no flags Details | Formatted Diff | Diff
Patch (16.89 KB, patch)
2017-04-26 09:38 PDT, Andy Estes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2017-04-26 09:18:27 PDT
[macOS] Add picture-in-picture support to WebPlaybackControlsManager
Comment 1 Andy Estes 2017-04-26 09:20:24 PDT
rdar://problem/29875010
Comment 2 Andy Estes 2017-04-26 09:30:13 PDT
Created attachment 308257 [details]
Patch
Comment 3 Build Bot 2017-04-26 09:31:47 PDT
Attachment 308257 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/spi/cocoa/AVKitSPI.h:216:  Should not have spaces around = in property attributes.  [whitespace/property] [4]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Andy Estes 2017-04-26 09:38:39 PDT
Created attachment 308258 [details]
Patch
Comment 5 WebKit Commit Bot 2017-04-26 10:51:55 PDT
Comment on attachment 308258 [details]
Patch

Clearing flags on attachment: 308258

Committed r215811: <http://trac.webkit.org/changeset/215811>
Comment 6 WebKit Commit Bot 2017-04-26 10:51:56 PDT
All reviewed patches have been landed.  Closing bug.