Bug 171325 - Speedometer: Add a Vue.js TodoMVC implementation
Summary: Speedometer: Add a Vue.js TodoMVC implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Addy Osmani
URL:
Keywords:
Depends on:
Blocks: 170513
  Show dependency tree / graph
 
Reported: 2017-04-26 08:49 PDT by Addy Osmani
Modified: 2019-05-02 16:18 PDT (History)
7 users (show)

See Also:

Attachments
Patch (279.87 KB, patch)
2017-04-26 08:51 PDT, Addy Osmani 		no flags Details | Formatted Diff | Diff
Patch (268.80 KB, patch)
2017-05-11 17:32 PDT, Addy Osmani 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Addy Osmani 2017-04-26 08:49:08 PDT 
As part of Speedometer 2.0 (https://bugs.webkit.org/show_bug.cgi?id=170513), this would add Vue.js, another popular JavaScript framework for building desktop and mobile web applications to the benchmark.
Comment 1 Addy Osmani 2017-04-26 08:51:04 PDT 
Created attachment 308252 [details]
Patch
Comment 2 Ryosuke Niwa 2017-05-09 14:30:53 PDT 
Comment on attachment 308252 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308252&action=review

> PerformanceTests/ChangeLog:7
> +        Adds a Vue.js TodoMVC implementation to Speedometer

Ditto a blank line before this.

> PerformanceTests/ChangeLog:9
> +        * Speedometer/resources/todomvc/architecture-examples/vuejs-cli/.babelrc: Added.

Do we really need to include these configuration files?

> PerformanceTests/ChangeLog:19
> +        (body,button,html):

Ditto remove these comments.
Comment 3 Addy Osmani 2017-05-11 17:32:14 PDT 
Created attachment 309833 [details]
Patch
Comment 4 Addy Osmani 2017-05-11 17:33:19 PDT 
Added a blank line above the CL title. The config files are needed for the app to build if we need to change it/fix any bugs in future. Removed the additional comments requested. PTAL.
Comment 5 Ryosuke Niwa 2017-05-11 19:54:32 PDT 
Comment on attachment 309833 [details]
Patch

Clearing flags on attachment: 309833

Committed r216720: <http://trac.webkit.org/changeset/216720>
Comment 6 Ryosuke Niwa 2017-05-11 19:54:34 PDT 
All reviewed patches have been landed.  Closing bug.