Bug 171323 – Speedometer: Add a Preact.js TodoMVC implementation

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Addy Osmani]

As part of Speedometer 2.0 (https://bugs.webkit.org/show_bug.cgi?id=170513), this tracks adding a TodoMVC implementation of Preact (https://preactjs.com/), a growing in popularity smaller alternative to React. I will also be separately landing an implementation using InfernoJS (another smaller alternative to React that uses different patterns to both React and Preact).

[Addy Osmani]

Created attachment 308250 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 308250 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308250&action=review

> PerformanceTests/ChangeLog:7
> +        Adds Preact.js TodoMVC implementation to Speedometer

Please add a blank line above this line.

[Addy Osmani]

Created attachment 309820 [details]
Patch

[Addy Osmani]

Added a blank line above and dropped extraneous inline comments in the changelog.

[Ryosuke Niwa]

Comment on attachment 309820 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309820&action=review

> PerformanceTests/Speedometer/resources/todomvc/architecture-examples/preact/src/index.html:15
> +        <script src="app.js"></script>

Where is app.js?

[Addy Osmani]

Created attachment 309838 [details]
Patch

[Addy Osmani]

Good catch on app.js. It appears the `build` directory where the final version gets used was ignored. I've renamed it to `dist` and will make sure the runner references that built version instead.

I've otherwise added a blank line where requested and dropped extra inline comments.

[Ryosuke Niwa]

Comment on attachment 309838 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309838&action=review

> PerformanceTests/ChangeLog:13
> +        * Speedometer/resources/todomvc/architecture-examples/preact/dist/index.html: Added.

Be sure to update the test suites accordingly.

[WebKit Commit Bot]

Comment on attachment 309838 [details]
Patch

Rejecting attachment 309838 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 309838, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
68f3165ab34cd5764fa
r216713 = 0f39ca8af1438b885163d4e799cd96825430c98e
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
Auto packing the repository in background for optimum performance.
See "git help gc" for manual housekeeping.
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
Auto packing the repository in background for optimum performance.
See "git help gc" for manual housekeeping.

Full output: http://webkit-queues.webkit.org/results/3722932

[Ryosuke Niwa]

Comment on attachment 309838 [details]
Patch

Try it again.

[Ryosuke Niwa]

Comment on attachment 309838 [details]
Patch

Clearing flags on attachment: 309838

Committed r216715: <http://trac.webkit.org/changeset/216715>

[Ryosuke Niwa]

All reviewed patches have been landed.  Closing bug.