Align colspan/rowspan limits with the latest HTML specification

[Simon Pieters (:zcorpan)]

HTML spec change:
https://github.com/whatwg/html/pull/1993

Tests:
https://github.com/w3c/web-platform-tests/pull/4115

[Chris Dumez]

Created attachment 308282 [details]
WIP Patch

[Chris Dumez]

Comment on attachment 308282 [details]
WIP Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308282&action=review

> LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-tabular-expected.txt:4308
> +FAIL th.colSpan: setAttribute() to 2147483648 assert_equals: IDL get expected 1000 but got 1

Still investigating those failures... not sure if the test is wrong or my implementation yet.

[Chris Dumez]

Created attachment 308284 [details]
WIP Patch

[Chris Dumez]

Created attachment 308288 [details]
WIP Patch

[Chris Dumez]

Created attachment 308290 [details]
WIP Patch

[Build Bot]

Comment on attachment 308290 [details]
WIP Patch

Attachment 308290 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3613480

New failing tests:
fast/table/giantRowspan.html
fast/table/giantRowspan2.html

[Build Bot]

Created attachment 308294 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Chris Dumez]

Created attachment 308297 [details]
Patch

[Build Bot]

Comment on attachment 308297 [details]
Patch

Attachment 308297 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3614647

New failing tests:
imported/w3c/web-platform-tests/html/dom/reflection-embedded.html
fast/table/giantRowspan.html

[Build Bot]

Created attachment 308313 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Chris Dumez]

Created attachment 308323 [details]
Patch

[Build Bot]

Comment on attachment 308323 [details]
Patch

Attachment 308323 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3615949

New failing tests:
imported/w3c/web-platform-tests/html/dom/reflection-embedded.html

[Build Bot]

Created attachment 308334 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Chris Dumez]

Created attachment 308339 [details]
Patch

[Chris Dumez]

Created attachment 308340 [details]
Patch

[Chris Dumez]

Created attachment 308421 [details]
Patch

[Chris Dumez]

Comment on attachment 308421 [details]
Patch

Patch is ready for review.

[Darin Adler]

Comment on attachment 308421 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308421&action=review

> Source/WebCore/html/parser/HTMLParserIdioms.cpp:157
> +static HTMLIntegerParsingError parseHTMLIntegerInternal(const CharacterType* position, const CharacterType* end, int& result)

Should this use std::expected instead?

[Alex Christensen]

I was commenting the same thing.  3x

[Chris Dumez]

Will re upload a patch using WTF::Expected. It does look much better.

[Chris Dumez]

Created attachment 308481 [details]
Patch

[Chris Dumez]

Created attachment 308482 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 308482 [details]
Patch

Clearing flags on attachment: 308482

Committed r215914: <http://trac.webkit.org/changeset/215914>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

*** Bug 68714 has been marked as a duplicate of this bug. ***