Bug 171316 - Encoded filename should be decoded for WKContentExtension.identifier
Summary: Encoded filename should be decoded for WKContentExtension.identifier
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-25 23:36 PDT by Alex Christensen
Modified: 2017-04-26 10:09 PDT (History)
2 users (show)

See Also:

Attachments
Patch (41.04 KB, patch)
2017-04-25 23:37 PDT, Alex Christensen 		aestes: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-04-25 23:36:55 PDT 
Encoded filename should be decoded for WKContentExtension.identifier
Comment 1 Alex Christensen 2017-04-25 23:37:31 PDT 
Created attachment 308223 [details]
Patch
Comment 2 Build Bot 2017-04-25 23:39:19 PDT 
Attachment 308223 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKContentExtensionStore.mm:148:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKContentExtensionStore.mm:161:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andy Estes 2017-04-26 10:06:12 PDT 
Comment on attachment 308223 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308223&action=review

> Source/WebKit2/UIProcess/API/APIContentExtensionStore.cpp:387
> +            auto contentExtension = createExtension(identifier, metaData, fileData);
> +            completionHandler(WTFMove(contentExtension), { });

I don't think you need a local variable for contentExtension.
Comment 4 Alex Christensen 2017-04-26 10:09:04 PDT 
http://trac.webkit.org/r215807