Bug 171306 - Speedometer: Update the vanilla JavaScript TodoMVC implem to a more recent version
Summary: Speedometer: Update the vanilla JavaScript TodoMVC implem to a more recent ve...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Addy Osmani
URL:
Keywords:
Depends on:
Blocks: 170513
  Show dependency tree / graph
 
Reported: 2017-04-25 18:24 PDT by Addy Osmani
Modified: 2017-05-11 19:53 PDT (History)
5 users (show)

See Also:

Attachments
Patch (98.65 KB, patch)
2017-04-26 08:12 PDT, Addy Osmani 		no flags Details | Formatted Diff | Diff
Patch (93.48 KB, patch)
2017-05-11 17:37 PDT, Addy Osmani 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Addy Osmani 2017-04-25 18:24:15 PDT 
As part of Speedometer 2.0 (https://bugs.webkit.org/show_bug.cgi?id=170513), the vanilla JavaScript implementation of TodoMVC needs to be updated to a more recent version.
Comment 1 Addy Osmani 2017-04-26 08:12:13 PDT 
Created attachment 308247 [details]
Patch
Comment 2 Ryosuke Niwa 2017-05-09 14:38:59 PDT 
Comment on attachment 308247 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308247&action=review

> PerformanceTests/ChangeLog:7
> +        Update vanilla JS TodoMVC implementation to the latest.

Please add a blank line above this.

> PerformanceTests/ChangeLog:95
> +        (html,):

Please remove these per-rule comments since we're just importing a file.
Comment 3 Addy Osmani 2017-05-11 17:37:28 PDT 
Created attachment 309834 [details]
Patch
Comment 4 Addy Osmani 2017-05-11 17:40:26 PDT 
Added a line above and removed per-rule comments. PTAL.
Comment 5 Ryosuke Niwa 2017-05-11 19:53:58 PDT 
Comment on attachment 309834 [details]
Patch

Clearing flags on attachment: 309834

Committed r216719: <http://trac.webkit.org/changeset/216719>
Comment 6 Ryosuke Niwa 2017-05-11 19:53:59 PDT 
All reviewed patches have been landed.  Closing bug.