The export macros for WebKit have a guard to prevent the GCC visibility attribute on ARM. This was originally done back in 2009 with https://trac.webkit.org/changeset/48251/webkit. It appears that armcc now supports the visibility attribute, http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0472j/chr1359124978628.html, so this can be enabled.
Created attachment 308169 [details] Patch Enables GCC visibility for armcc. GCC needs to be >= 4 to have support. Clang also exposes this macro.
This fixes the feedback from https://bugs.webkit.org/show_bug.cgi?id=171240 that wasn't gotten to before landing.
I don't think we support gcc older than 4.
(In reply to Alex Christensen from comment #3) > I don't think we support gcc older than 4. Yeah, GCC 4.0 was released in 2005 and there's no way to compile WebKit with anything less than GCC 4.9. We have checks to prevent this in other places. No need for that version test.
Comment on attachment 308169 [details] Patch Ok, that's what I thought. Let's just remove the checks.
Created attachment 308265 [details] Patch with GCC 4 check removed
Comment on attachment 308265 [details] Patch with GCC 4 check removed Clearing flags on attachment: 308265 Committed r215817: <http://trac.webkit.org/changeset/215817>
All reviewed patches have been landed. Closing bug.