Bug 171294 – Move mediaCaptureEnabled from WKWebViewConfiguration to WKPreferences

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[Andrew Gold]

Move the mediaCaptureEnabled setting from WKWebViewConfiguration to WKPreferences so that it can be toggled dynamically.

[Andrew Gold]

rdar://problem/31817010

[Andrew Gold]

Created attachment 308155 [details]
proposed patch.

[Build Bot]

Attachment 308155 [details] did not pass style-queue:


ERROR: Source/WebKit2/ChangeLog:14:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebKit2/ChangeLog:19:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andrew Gold]

Created attachment 308156 [details]
proposed patch v2.

[Andrew Gold]

Created attachment 308159 [details]
proposed patch v3.

[Jon Lee]

(In reply to Andrew Gold from comment #5)
> Created attachment 308159 [details]
> proposed patch v3.

application/mbox?

[Eric Carlson]

Comment on attachment 308159 [details]
proposed patch v3.

View in context: https://bugs.webkit.org/attachment.cgi?id=308159&action=review

> Source/WebKit2/UIProcess/UserMediaProcessManager.cpp:-121
> -#if !PLATFORM(IOS)
>              if (&manager->page() == &pageStartingCapture)
>                  continue;
> -#endif

Did you mean to include this?

[Andrew Gold]

(In reply to Eric Carlson from comment #7)
> Comment on attachment 308159 [details]
> proposed patch v3.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=308159&action=review
> 
> > Source/WebKit2/UIProcess/UserMediaProcessManager.cpp:-121
> > -#if !PLATFORM(IOS)
> >              if (&manager->page() == &pageStartingCapture)
> >                  continue;
> > -#endif
> 
> Did you mean to include this?

I did not. I will upload a revised version.

[Andrew Gold]

Created attachment 308248 [details]
proposed patch v4.

[Build Bot]

Attachment 308248 [details] did not pass style-queue:


ERROR: Source/WebKit2/ChangeLog:25:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andrew Gold]

Created attachment 308249 [details]
proposed patch 5

[WebKit Commit Bot]

Comment on attachment 308249 [details]
proposed patch 5

Clearing flags on attachment: 308249

Committed r215801: <http://trac.webkit.org/changeset/215801>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.