Bug 171283 – Web Inspector: "Space" localized string is not loaded in combined and minified builds

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Summary:
"Space" localized string is not loaded in combined and minified builds

Steps to Reproduce:
1. Build and optimized build
2. Open inspector
3. Show Timeline Tab
4. Hover Record button
  => Localized string not found for "Space"

[Joseph Pecoraro]

<rdar://problem/30871371>

[Joseph Pecoraro]

Created attachment 308127 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Created attachment 308128 [details]
[PATCH] Proposed Fix

[Blaze Burg]

Comment on attachment 308128 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=308128&action=review

r=me

> Source/WebInspectorUI/UserInterface/Models/Resource.js:694
> +        console.assert(!isNaN(size), "Size should be a valid number.");

This seems unrelated, but whatever.

> Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:1782
> +            console.assert(breakpointTreeElement, "Missing breakpoint descendant.", this);

Ditto.

[WebKit Commit Bot]

Comment on attachment 308128 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 308128

Committed r215755: <http://trac.webkit.org/changeset/215755>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Joseph Pecoraro]

(In reply to Brian Burg from comment #4)
> Comment on attachment 308128 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=308128&action=review
> 
> r=me
> 
> > Source/WebInspectorUI/UserInterface/Models/Resource.js:694
> > +        console.assert(!isNaN(size), "Size should be a valid number.");
> 
> This seems unrelated, but whatever.

These are explained in the changelog. They are warnings produced by the optimizer, which is related to this bug (an issue only seen in optimized builds).