Bug 171283 - Web Inspector: "Space" localized string is not loaded in combined and minified builds
Summary: Web Inspector: "Space" localized string is not loaded in combined and minifie...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-04-25 12:21 PDT by Joseph Pecoraro
Modified: 2017-04-25 13:39 PDT (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (6.45 KB, patch)
2017-04-25 12:24 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (6.45 KB, patch)
2017-04-25 12:25 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-04-25 12:21:29 PDT 
Summary:
"Space" localized string is not loaded in combined and minified builds

Steps to Reproduce:
1. Build and optimized build
2. Open inspector
3. Show Timeline Tab
4. Hover Record button
  => Localized string not found for "Space"
Comment 1 Joseph Pecoraro 2017-04-25 12:21:38 PDT 
<rdar://problem/30871371>
Comment 2 Joseph Pecoraro 2017-04-25 12:24:57 PDT 
Created attachment 308127 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2017-04-25 12:25:47 PDT 
Created attachment 308128 [details]
[PATCH] Proposed Fix
Comment 4 BJ Burg 2017-04-25 13:01:35 PDT 
Comment on attachment 308128 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=308128&action=review

r=me

> Source/WebInspectorUI/UserInterface/Models/Resource.js:694
> +        console.assert(!isNaN(size), "Size should be a valid number.");

This seems unrelated, but whatever.

> Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:1782
> +            console.assert(breakpointTreeElement, "Missing breakpoint descendant.", this);

Ditto.
Comment 5 WebKit Commit Bot 2017-04-25 13:38:03 PDT 
Comment on attachment 308128 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 308128

Committed r215755: <http://trac.webkit.org/changeset/215755>
Comment 6 WebKit Commit Bot 2017-04-25 13:38:05 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Joseph Pecoraro 2017-04-25 13:39:20 PDT 
(In reply to Brian Burg from comment #4)
> Comment on attachment 308128 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=308128&action=review
> 
> r=me
> 
> > Source/WebInspectorUI/UserInterface/Models/Resource.js:694
> > +        console.assert(!isNaN(size), "Size should be a valid number.");
> 
> This seems unrelated, but whatever.

These are explained in the changelog. They are warnings produced by the optimizer, which is related to this bug (an issue only seen in optimized builds).